From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylvain BERTRAND Subject: radeon pm questions Date: Mon, 29 Apr 2013 03:26:28 +0200 Message-ID: <20130429012608.GA648@freedom> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from bounce-vit-1.online.net (bounce-vit-1.online.net [88.190.253.79]) by gabe.freedesktop.org (Postfix) with ESMTP id 7446AE5CAB for ; Sun, 28 Apr 2013 18:50:06 -0700 (PDT) Received: from [88.190.253.253] (helo=smtpauth-vit.online.net) by bounce-vit-1.online.net with esmtpa (Exim 4.71) (envelope-from ) id 1UWcrO-00046U-9p for dri-devel@lists.freedesktop.org; Mon, 29 Apr 2013 03:26:30 +0200 Received: from [88.188.175.165] (helo=localhost) by smtpauth-vit.online.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UWe62-0005C5-Q3 for dri-devel@lists.freedesktop.org; Mon, 29 Apr 2013 04:45:42 +0200 Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi, I have a few questions about radeon pm code: ---- In radeon_atombios.c, radeon_atombios_parse_power_table_6 function, power_state->v2.nonClockInfoIndex for non_clock_info of one state is ignored and replaced by the state index, referencing an iguana bug. Is it still buggy from southern island and we must keep ignoring power_state->v2.nonClockInfoIndex for good and use the state index to reference the right state description in non clock array table? ---- ---- The same does happen for the clock info index which can be out of range. Same treat as above? ---- ---- In radeon_atombios.c, radeon_atombios_parse_pplib_clock_info function, code paths are selected based on DCE generation. The same happens in radeon_atombios_parse_pplib_non_clock_info function. Should it rather be the chip family? Or current powerplay code does deal only with the DCE block?? ---- regards, -- Sylvain