From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
liam.r.girdwood@intel.com
Subject: Re: [PATCH] ALSA: compress: fix the states to check for allowing read
Date: Mon, 29 Apr 2013 14:27:11 +0530 [thread overview]
Message-ID: <20130429085711.GK24632@intel.com> (raw)
In-Reply-To: <s5hehdt1ymt.wl%tiwai@suse.de>
On Mon, Apr 29, 2013 at 11:20:42AM +0200, Takashi Iwai wrote:
> > I started with switch and then didnt want to code for all the PCM_STATES... but
> > yes that makes more sense, i will send that right away.
>
> You can code like
> switch (stream->runtime->state) {
> case SNDRV_PCM_STATE_RUNNING:
> case SNDRV_PCM_STATE_DRAINING:
> case SNDRV_PCM_STATE_PAUSED:
> case SNDRV_PCM_STATE_SETUP:
> break; /* OK */
> default:
> retval = -EBADFD;
> break;
> }
Yup, and i did exactly opposite, let me know if you want like this :)
--
~Vinod
next prev parent reply other threads:[~2013-04-29 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 8:05 [PATCH] ALSA: compress: fix the states to check for allowing read Vinod Koul
2013-04-29 8:55 ` Takashi Iwai
2013-04-29 8:45 ` Vinod Koul
2013-04-29 9:20 ` Takashi Iwai
2013-04-29 8:57 ` Vinod Koul [this message]
2013-04-29 9:29 ` Richard Fitzgerald
2013-04-29 9:00 ` Vinod Koul
2013-04-29 11:07 ` Mark Brown
2013-04-29 10:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429085711.GK24632@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.