From: Mark Brown <broonie@kernel.org>
To: Leon Romanovsky <leon@leon.nu>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
patches <patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: wm8962: Convert to devm_input_allocate_device()
Date: Mon, 29 Apr 2013 11:19:59 +0100 [thread overview]
Message-ID: <20130429101959.GE5019@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CALq1K=+=J9oPGvbrXuhS=Bgqj+viC5EAkTHKkNuHxBadExpXdA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]
On Sun, Apr 28, 2013 at 09:32:18PM +0300, Leon Romanovsky wrote:
> I think the reason of our misunderstanding is due to the name of
> input_free_device call. From the code, it is device destroy function,
> and the freeing itself done as an error handling of
> input_register_device
> (http://lxr.free-electrons.com/source/drivers/input/input.c#L2114).
> How do you think we need to proceed? Do I need to send patches with
> explicit call to input_free_device function?
I really think the input API needs to be looked at here, this is all way
too error prone. Calling input_free_device() on something allocated
using devm_ looks like an error itself...
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-04-29 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 13:18 [PATCH] ASoC: wm8962: Convert to devm_input_allocate_device() Mark Brown
2013-04-24 13:50 ` Leon Romanovsky
2013-04-25 12:52 ` Mark Brown
2013-04-28 5:00 ` Leon Romanovsky
2013-04-28 9:47 ` Mark Brown
2013-04-28 18:32 ` Leon Romanovsky
2013-04-29 10:19 ` Mark Brown [this message]
2013-04-29 17:47 ` [alsa-devel] " Leon Romanovsky
2013-04-29 18:07 ` Dmitry Torokhov
2013-04-29 18:19 ` Dmitry Torokhov
2013-04-29 18:52 ` Leon Romanovsky
2013-04-29 20:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429101959.GE5019@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=leon@leon.nu \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.