From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 29 Apr 2013 22:48:59 +0200 Subject: [Buildroot] [PATCH 1/2] rpi-firmware: Fixup config.txt In-Reply-To: <1358087034-2706-1-git-send-email-maxime.hadjinlian@gmail.com> References: <1358087034-2706-1-git-send-email-maxime.hadjinlian@gmail.com> Message-ID: <20130429224859.484e28f9@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Maxime Hadjinlian, On Sun, 13 Jan 2013 15:23:53 +0100, Maxime Hadjinlian wrote: > The default name of the kernel binary for the RaspberryPi is kernel.img, it's a > only a zImage kernel renamed. > Since Buildroot will build a zImage, the default config uses that should use it > instead of forcing the user to rename a file. > > Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver, > there is no need to specify it on the cmdline. I don't think this justification is correct. If ext4 is a module, then rootfstype=ext4 doesn't make it work better. Specifying rootfstype= tells the kernel what is the root filesystem, so that it doesn't have to test the different available filesystem drivers. I'm ok with the change, but I think the commit log is not correct. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com