All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 01/13] Bluetooth: Fix start_discovery for LE-only controllers
Date: Tue, 30 Apr 2013 09:43:04 +0300	[thread overview]
Message-ID: <20130430064304.GA29654@x220> (raw)
In-Reply-To: <1367300704-703-2-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

On Tue, Apr 30, 2013, Andre Guedes wrote:
> LE-only controllers don't have local extended features (see commit
> c73eee9172bf061202c75ad4d16506a7efd04d1c). Thus, lmp_host_le_capable
> helper is not applicable and we should use test_bit(HCI_LE_ENABLED)
> to check if the host supports LE. Otherwise, start_discovery will
> always fail for LE-only controllers.
> 
> This misbehavior can be easily checked by running mgmt-tester tool
> (test "Start Discovery - Success 2" will fail).
> 
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
>  net/bluetooth/mgmt.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I already sent a patch for this last Wednesday:

  Bluetooth: Fix checks for LE support on LE-only controllers

So this patch can be ignored.

Johan

  reply	other threads:[~2013-04-30  6:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  5:44 [PATCH v2 00/13] Update Discovery to use HCI request framework Andre Guedes
2013-04-30  5:44 ` [PATCH v2 01/13] Bluetooth: Fix start_discovery for LE-only controllers Andre Guedes
2013-04-30  6:43   ` Johan Hedberg [this message]
2013-04-30 18:06     ` Andre Guedes
2013-04-30  5:44 ` [PATCH v2 02/13] Bluetooth: Make inquiry_cache_flush non-static Andre Guedes
2013-04-30  8:21   ` Johan Hedberg
2013-04-30  5:44 ` [PATCH v2 03/13] Bluetooth: Update start_discovery to use HCI request Andre Guedes
2013-04-30  8:24   ` Johan Hedberg
2013-04-30  5:44 ` [PATCH v2 04/13] Bluetooth: Remove start discovery handling from hci_event.c Andre Guedes
2013-04-30  8:25   ` Johan Hedberg
2013-04-30 18:06     ` Andre Guedes
2013-04-30  5:44 ` [PATCH v2 05/13] Bluetooth: Move discovery macros to hci_core.h Andre Guedes
2013-04-30  8:27   ` Johan Hedberg
2013-04-30  5:44 ` [PATCH v2 06/13] Bluetooth: Use HCI request in interleaved discovery Andre Guedes
2013-04-30  8:34   ` Johan Hedberg
2013-04-30 18:06     ` Andre Guedes
2013-04-30  5:44 ` [PATCH v2 07/13] Bluetooth: Update stop_discovery to use HCI request Andre Guedes
2013-04-30  8:34   ` Johan Hedberg
2013-04-30  5:44 ` [PATCH v2 08/13] Bluetooth: Remove stop discovery handling from hci_event.c Andre Guedes
2013-04-30  8:36   ` Johan Hedberg
2013-04-30 18:06     ` Andre Guedes
2013-04-30  5:45 ` [PATCH v2 09/13] Bluetooth: Refactor hci_cc_le_set_scan_enable Andre Guedes
2013-04-30  8:36   ` Johan Hedberg
2013-04-30  5:45 ` [PATCH v2 10/13] Bluetooth: Remove LE scan helpers Andre Guedes
2013-04-30  8:36   ` Johan Hedberg
2013-04-30  5:45 ` [PATCH v2 11/13] Bluetooth: Remove inquiry helpers Andre Guedes
2013-04-30  8:37   ` Johan Hedberg
2013-04-30  5:45 ` [PATCH v2 12/13] Bluetooth: Remove empty event handler Andre Guedes
2013-04-30  8:37   ` Johan Hedberg
2013-04-30  5:45 ` [PATCH v2 13/13] Bluetooth: Mgmt Device Found Event Andre Guedes
2013-04-30  8:38   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130430064304.GA29654@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.