From: Dan Carpenter <dan.carpenter@oracle.com>
To: elder@inktank.com
Cc: ceph-devel@vger.kernel.org
Subject: re: rbd: enforce parent overlap
Date: Tue, 30 Apr 2013 10:24:10 +0300 [thread overview]
Message-ID: <20130430072410.GA7237@elgon.mountain> (raw)
Hello Alex Elder,
This is a semi-automatic email about new static checker warnings.
The patch 64548e0638af: "rbd: enforce parent overlap" from Apr 21,
2013, leads to the following Smatch complaint:
drivers/block/rbd.c:1449 rbd_osd_read_callback()
error: we previously assumed 'img_request' could be null (see line 1448)
drivers/block/rbd.c
1447 img_request = obj_request->img_request;
1448 layered = img_request && img_request_layered_test(img_request);
^^^^^^^^^^^
Old check.
1449 rbd_dev = img_request->rbd_dev;
^^^^^^^^^^^^^^^^^^^^
New dereference.
1450 }
1451
regards,
dan carpenter
next reply other threads:[~2013-04-30 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 7:24 Dan Carpenter [this message]
2013-04-30 11:57 ` rbd: enforce parent overlap Alex Elder
2013-04-30 13:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430072410.GA7237@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.