From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Tue, 30 Apr 2013 10:34:16 +0000 Subject: Re: [PATCH V2] video: implement a simple framebuffer driver Message-Id: <201304301234.16992.arnd@arndb.de> List-Id: References: <1365043183-28905-1-git-send-email-swarren@wwwdotorg.org> <517F753F.5090909@ti.com> In-Reply-To: <517F753F.5090909@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tuesday 30 April 2013, Tomi Valkeinen wrote: > > + framebuffer { > > + compatible = "simple-framebuffer"; > > + reg = <0x1d385000 (1600 * 1200 * 2)>; > > + width = <1600>; > > + height = <1200>; > > + stride = <(1600 * 2)>; > > + format = "r5g6b5"; > > + }; > > I'm not an expert on DT, but I think the point of DT is to describe the > hardware. This doesn't describe the hardware at all. That's ok. It's not uncommon to have settings in the device tree that describe how hardware is set up. Other similar properties would be the line rate of a serial port, or a keymap describing what each button is labeled. They are not physical properties, but they are necessary platform specific pieces of information that are not available otherwise. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 30 Apr 2013 12:34:16 +0200 Subject: [PATCH V2] video: implement a simple framebuffer driver In-Reply-To: <517F753F.5090909@ti.com> References: <1365043183-28905-1-git-send-email-swarren@wwwdotorg.org> <517F753F.5090909@ti.com> Message-ID: <201304301234.16992.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 30 April 2013, Tomi Valkeinen wrote: > > + framebuffer { > > + compatible = "simple-framebuffer"; > > + reg = <0x1d385000 (1600 * 1200 * 2)>; > > + width = <1600>; > > + height = <1200>; > > + stride = <(1600 * 2)>; > > + format = "r5g6b5"; > > + }; > > I'm not an expert on DT, but I think the point of DT is to describe the > hardware. This doesn't describe the hardware at all. That's ok. It's not uncommon to have settings in the device tree that describe how hardware is set up. Other similar properties would be the line rate of a serial port, or a keymap describing what each button is labeled. They are not physical properties, but they are necessary platform specific pieces of information that are not available otherwise. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V2] video: implement a simple framebuffer driver Date: Tue, 30 Apr 2013 12:34:16 +0200 Message-ID: <201304301234.16992.arnd@arndb.de> References: <1365043183-28905-1-git-send-email-swarren@wwwdotorg.org> <517F753F.5090909@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <517F753F.5090909@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, Stephen Warren , devicetree-discuss@lists.ozlabs.org, Rob Clark , linux-rpi-kernel@lists.infradead.org, Olof Johansson , Andrew Morton , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tuesday 30 April 2013, Tomi Valkeinen wrote: > > + framebuffer { > > + compatible = "simple-framebuffer"; > > + reg = <0x1d385000 (1600 * 1200 * 2)>; > > + width = <1600>; > > + height = <1200>; > > + stride = <(1600 * 2)>; > > + format = "r5g6b5"; > > + }; > > I'm not an expert on DT, but I think the point of DT is to describe the > hardware. This doesn't describe the hardware at all. That's ok. It's not uncommon to have settings in the device tree that describe how hardware is set up. Other similar properties would be the line rate of a serial port, or a keymap describing what each button is labeled. They are not physical properties, but they are necessary platform specific pieces of information that are not available otherwise. Arnd