From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: [PATCH] dm table: fix logic bug in dm_table_supports_write_same [was: Re: BLKZEROOUT on dm devices] Date: Tue, 30 Apr 2013 12:32:14 -0400 Message-ID: <20130430163214.GA22690@redhat.com> References: Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Bharata B Rao Cc: dm-devel@redhat.com List-Id: dm-devel.ids T24gVHVlLCBBcHIgMzAgMjAxMyBhdCAxMjowN2FtIC0wNDAwLApCaGFyYXRhIEIgUmFvIDxiaGFy YXRhLnJhb0BnbWFpbC5jb20+IHdyb3RlOgoKPiBIaSwKPiAKPiBJcyBCTEtaRVJPT1VUIGlvY3Rs IHN1cHBvc2VkIHRvIHdvcmsgb24gZG0gZGV2aWNlcyA/IFdoZW4gSSB0cnkgdGhpcwo+IGlvY3Rs IG9uIGFuIExWIHRoYXQgc2l0cyBvbiBhIFdSSVRFIFNBTUUgY2FwYWJsZSBTQ1NJIGRldmljZSwg SSBzZWUKPiB0aGF0IGNvbnZlbnRpb25hbCB6ZXJvaW5nIGlzIGRvbmUgc2luY2UgdGhlIFdSSVRF IFNBTUUgc3VwcG9ydCBpc24ndAo+IGFkdmVydGlzZWQgYnkgdGhlIGRtIGRldmljZS4KPiAKPiAj IGxzYmxrCj4gTkFNRSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTUFKOk1JTiBSTSAgIFNJ WkUgUk8gVFlQRSAgTU9VTlRQT0lOVAo+IHNkYSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgODowICAgIDAgICAgNTBHICAwIGRpc2sKPiDilJTilIBtcGF0aGIgKGRtLTEyKSAgICAgICAg ICAgICAgICAgMjUyOjEyICAgMCAgICA1MEcgIDAgbXBhdGgKPiAgIOKUlOKUgHdzX3ZnLWx2b2ww IChkbS0xMSkgICAgICAgICAgMjUyOjExICAgMCAgICAgMUcgIDAgbHZtCj4gc2RlICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA4OjY0ICAgMCAgICA1MEcgIDAgZGlzawo+IOKUlOKUgG1w YXRoYiAoZG0tMTIpICAgICAgICAgICAgICAgICAyNTI6MTIgICAwICAgIDUwRyAgMCBtcGF0aAo+ ICAg4pSU4pSAd3NfdmctbHZvbDAgKGRtLTExKSAgICAgICAgICAyNTI6MTEgICAwICAgICAxRyAg MCBsdm0KPiAKPiAjIGNhdCAvc3lzL2Jsb2NrL3NkYS9xdWV1ZS93cml0ZV9zYW1lX21heF9ieXRl cwo+IDI2ODQzNTQ1Ngo+ICMgY2F0IC9zeXMvYmxvY2svZG0tMTIvcXVldWUvd3JpdGVfc2FtZV9t YXhfYnl0ZXMKPiAwCj4gIyBjYXQgL3N5cy9ibG9jay9kbS0xMS9xdWV1ZS93cml0ZV9zYW1lX21h eF9ieXRlcwo+IDAKPiAKPiBbcm9vdEBsbG12bTAyIH5dIyBjYXQgL3N5cy9kZXYvYmxvY2svOFw6 MC9xdWV1ZS93cml0ZV9zYW1lX21heF9ieXRlcwo+IDI2ODQzNTQ1Ngo+IFtyb290QGxsbXZtMDIg fl0jIGNhdCAvc3lzL2Rldi9ibG9jay8yNTJcOjEyL3F1ZXVlL3dyaXRlX3NhbWVfbWF4X2J5dGVz Cj4gMAo+IFtyb290QGxsbXZtMDIgfl0jIGNhdCAvc3lzL2Rldi9ibG9jay8yNTJcOjExL3F1ZXVl L3dyaXRlX3NhbWVfbWF4X2J5dGVzCj4gMAoKU3VyZSBlbm91Z2ggSSBzZWUgdGhlIHNhbWUgbGlt aXRzIHN0YWNraW5nIHByb2JsZW0geW91IHJlcG9ydGVkOgoKIyBtb2Rwcm9iZSBzY3NpX2RlYnVn IGRldl9zaXplX21iPTEwMCBsYnB3cz0xCi4uLgpzZCA1OjA6MDowOiBbc2RoXSBBdHRhY2hlZCBT Q1NJIGRpc2sKCiMgY2F0IC9zeXMvYmxvY2svc2RoL3F1ZXVlL3dyaXRlX3NhbWVfbWF4X2J5dGVz CjMzNTUzOTIwCih3aGljaCByZWZsZWN0cyBzY3NpX2RlYnVnJ3Mgd3JpdGVfc2FtZV9sZW5ndGgg ZGVmYXVsdCBvZiAweGZmZmYgKiA1MTJiKQoKIyBlY2hvICIwIGBibG9ja2RldiAtLWdldHN6IC9k ZXYvc2RoYCBsaW5lYXIgL2Rldi9zZGggMCIgfCBkbXNldHVwIGNyZWF0ZSB0ZXN0CiMgcmVhZGxp bmsgL2Rldi9tYXBwZXIvdGVzdAouLi9kbS00CiMgY2F0IC9zeXMvYmxvY2svZG0tNC9xdWV1ZS93 cml0ZV9zYW1lX21heF9ieXRlcyAKMAoKPiBGcm9tIGNvbW1pdCBkNTRlYWE1YTBmZGUwYTIwMmU0 ZTkxZjIwMGY4MThlZGNlZjE1YmVlLCBJIGdhdGhlciB0aGF0Cj4gV1JJVEUgU0FNRSBpcyBhZHZl cnRpc2VkIGJ5IGEgZG0gZGV2aWNlIGlmIGFsbCBvZiBpdHMgdGFyZ2V0IGFuZAo+IHVuZGVybHlp bmcgZGV2aWNlcyBzdXBwb3J0IFdSSVRFIFNBTUUuIEFsc28gYXMgcGVyCj4gNGYwYjcwYjA0Nzkx MDE1MjJiODY0NWRkYzFmNWVlNzEzNzgyMWRiMywgV1JJVEUgU0FNRSBpcyBzdXBwb3J0ZWQgZm9y Cj4gbGluZWFyIGRtIGRldmljZXMuIEJvdGggb2YgdGhlc2Ugc2VlbSB0byBiZSB0cnVlIGluIG15 IGNhc2UsIGJ1dCBzdGlsbAo+IEJMS1pFUk9PVVQgaW9jdGwgcmVzb3J0cyB0byBjb252ZW50aW9u YWwgemVyb2luZy4gV2hhdCBhbSBJIG1pc3NpbmcKPiBoZXJlID8KClRoZSBmaXJzdCBwYXRjaCBv ZiBteSBXUklURSBTQU1FIHBhdGNoc2V0IHRoYXQgSSBwb3N0ZWQgdG8gZG0tZGV2ZWwgd2FzCnR3 ZWFrZWQgYmVmb3JlIGdvaW5nIHVwc3RyZWFtOgpodHRwOi8vd3d3LnJlZGhhdC5jb20vYXJjaGl2 ZXMvZG0tZGV2ZWwvMjAxMi1EZWNlbWJlci9tc2cwMDA2NC5odG1sCgpEdWUgdG8gaXRlcmF0ZV9k ZXZpY2VzIGRpc3Bvc2l0aW9uIHRvIHNob3J0LWNpcmN1aXQgaWYgdGhlIHRlc3QgZnVuYygpCnJl dHVybnMgdHJ1ZSwgaXQgbG9va3MgbGlrZSBBbGFzZGFpciBjb3JyZWN0bHkgY2hhbmdlZCAKcy9k ZXZpY2Vfd3JpdGVfc2FtZV9jYXBhYmxlL2RldmljZV9ub3Rfd3JpdGVfc2FtZV9jYXBhYmxlLyBi dXQgZm9yZ290IHRvCmludmVydCB0aGUgbG9naWMgb2YgdGhlIGNhbGxpbmcgaXRlcmF0ZV9kZXZp Y2VzIGluCmRtX3RhYmxlX3N1cHBvcnRzX3dyaXRlX3NhbWUoKS4KCkFueXdheSwgdGhpcyBwYXRj aCBmaXhlcyB0aGluZ3MgZm9yIG1lOgoKRnJvbTogTWlrZSBTbml0emVyIDxzbml0emVyQHJlZGhh dC5jb20+CkRhdGU6IFR1ZSwgMzAgQXByIDIwMTMgMTI6MjQ6NTggLTA0MDAKU3ViamVjdDogW1BB VENIXSBkbSB0YWJsZTogZml4IGxvZ2ljIGJ1ZyBpbiBkbV90YWJsZV9zdXBwb3J0c193cml0ZV9z YW1lCgpJZiBkZXZpY2Vfbm90X3dyaXRlX3NhbWVfY2FwYWJsZSgpIHJldHVybnMgdHJ1ZSB0aGVu IHRoZSBpdGVyYXRlX2RldmljZXMKbG9vcCBpbiBkbV90YWJsZV9zdXBwb3J0c193cml0ZV9zYW1l KCkgc2hvdWxkIHJldHVybiBmYWxzZS4KClJlcG9ydGVkLWJ5OiBCaGFyYXRhIEIgUmFvIDxiaGFy YXRhLnJhb0BnbWFpbC5jb20+ClNpZ25lZC1vZmYtYnk6IE1pa2UgU25pdHplciA8c25pdHplckBy ZWRoYXQuY29tPgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHYzLjgrCi0tLQogZHJpdmVy cy9tZC9kbS10YWJsZS5jIHwgICAgMiArLQogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZC9kbS10YWJsZS5jIGIv ZHJpdmVycy9tZC9kbS10YWJsZS5jCmluZGV4IDNmZTc5N2YuLmQ4MDE2ODIgMTAwNjQ0Ci0tLSBh L2RyaXZlcnMvbWQvZG0tdGFibGUuYworKysgYi9kcml2ZXJzL21kL2RtLXRhYmxlLmMKQEAgLTE0 NDUsNyArMTQ0NSw3IEBAIHN0YXRpYyBib29sIGRtX3RhYmxlX3N1cHBvcnRzX3dyaXRlX3NhbWUo c3RydWN0IGRtX3RhYmxlICp0KQogCQkJcmV0dXJuIGZhbHNlOwogCiAJCWlmICghdGktPnR5cGUt Pml0ZXJhdGVfZGV2aWNlcyB8fAotCQkgICAgIXRpLT50eXBlLT5pdGVyYXRlX2RldmljZXModGks IGRldmljZV9ub3Rfd3JpdGVfc2FtZV9jYXBhYmxlLCBOVUxMKSkKKwkJICAgIHRpLT50eXBlLT5p dGVyYXRlX2RldmljZXModGksIGRldmljZV9ub3Rfd3JpdGVfc2FtZV9jYXBhYmxlLCBOVUxMKSkK IAkJCXJldHVybiBmYWxzZTsKIAl9CiAKLS0gCjEuNy4xCgotLQpkbS1kZXZlbCBtYWlsaW5nIGxp c3QKZG0tZGV2ZWxAcmVkaGF0LmNvbQpodHRwczovL3d3dy5yZWRoYXQuY29tL21haWxtYW4vbGlz dGluZm8vZG0tZGV2ZWw=