From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zoran Markovic <zoran.markovic@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Benoit Goby <benoit@android.com>,
Android Kernel Team <kernel-team@android.com>,
Colin Cross <ccross@android.com>,
Todd Poynor <toddpoynor@google.com>, San Mehat <san@google.com>,
John Stultz <john.stultz@linaro.org>, Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Len Brown <len.brown@intel.com>
Subject: Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.
Date: Tue, 30 Apr 2013 16:30:31 -0700 [thread overview]
Message-ID: <20130430233031.GA32310@kroah.com> (raw)
In-Reply-To: <1367360914-23389-1-git-send-email-zoran.markovic@linaro.org>
On Tue, Apr 30, 2013 at 03:28:33PM -0700, Zoran Markovic wrote:
> From: Benoit Goby <benoit@android.com>
>
> Below is a patch from android kernel that detects a driver suspend
> lockup and captures dump in the kernel log. Please review and provide
> comments.
There's this really cool thing called a watchdog driver that does stuff
like this :)
> Rather than hard-lock the kernel, dump the suspend thread stack and
> BUG() when a driver takes too long to suspend. The timeout is set to
> 12 seconds to be longer than the usbhid 10 second timeout.
>
> Exclude from the watchdog the time spent waiting for children that
> are resumed asynchronously and time every device, whether or not they
> resumed synchronously.
No, don't add a driver-core-only timer, use the existing watchdog timers
if you are worried about the kernel locking up.
thanks,
greg k-h
next prev parent reply other threads:[~2013-04-30 23:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 22:28 [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend Zoran Markovic
2013-04-30 22:28 ` [RFC PATCH] power: Add option to log time spent in suspend Zoran Markovic
2013-05-01 0:29 ` Pavel Machek
2013-05-01 3:29 ` Colin Cross
2013-05-02 12:27 ` Pavel Machek
2013-05-02 18:29 ` Colin Cross
2013-05-02 18:58 ` John Stultz
2013-05-02 19:11 ` Colin Cross
2013-04-30 23:30 ` Greg Kroah-Hartman [this message]
2013-05-01 3:36 ` [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend Colin Cross
2013-05-01 4:17 ` Greg Kroah-Hartman
2013-05-01 4:39 ` Colin Cross
[not found] ` <CAK7N6voYXxJKWDwSj5T9Y2fKK+Y5JqN9Wm8Qoffi9N7nRnsYhw@mail.gmail.com>
2013-05-01 5:14 ` Colin Cross
2013-05-01 0:30 ` Pavel Machek
2013-05-01 3:39 ` Colin Cross
2013-05-01 10:56 ` Pavel Machek
2013-05-01 16:10 ` Colin Cross
2013-05-01 16:24 ` Greg Kroah-Hartman
2013-05-02 12:30 ` Pavel Machek
2013-05-02 18:25 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430233031.GA32310@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benoit@android.com \
--cc=ccross@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=san@google.com \
--cc=toddpoynor@google.com \
--cc=zoran.markovic@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.