From: Mike Snitzer <snitzer@redhat.com>
To: Bharata B Rao <bharata.rao@gmail.com>
Cc: dm-devel@redhat.com
Subject: [PATCH] dm mpath: enable WRITE SAME support
Date: Wed, 1 May 2013 09:29:22 -0400 [thread overview]
Message-ID: <20130501132922.GA10432@redhat.com> (raw)
In-Reply-To: <CAGZKiBrQmLGcUYKKBbyHSRsTSr28V=ap+OE1YuSDVcJnRb4Dqg@mail.gmail.com>
On Wed, May 01 2013 at 2:58am -0400,
Bharata B Rao <bharata.rao@gmail.com> wrote:
> On Tue, Apr 30, 2013 at 10:02 PM, Mike Snitzer <snitzer@redhat.com> wrote:
> > On Tue, Apr 30 2013 at 12:07am -0400,
> > Bharata B Rao <bharata.rao@gmail.com> wrote:
> >
> >>
> >> # lsblk
> >> NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
> >> sda 8:0 0 50G 0 disk
> >> └─mpathb (dm-12) 252:12 0 50G 0 mpath
> >> └─ws_vg-lvol0 (dm-11) 252:11 0 1G 0 lvm
> >> sde 8:64 0 50G 0 disk
> >> └─mpathb (dm-12) 252:12 0 50G 0 mpath
> >> └─ws_vg-lvol0 (dm-11) 252:11 0 1G 0 lvm
> >>
> >
> >
> > Anyway, this patch fixes things for me:
>
> Thanks, this fixes the issue for me too. However if LV/VG/PV are
> created on multipath device, then WRITE SAME still doesn't get
> advertised for the LV. I had to disable multipath and re-create
> LV/VG/PV on a normal device (/dev/sda as against /dev/mapper/mapathb)
> to get BLKZEROUT working on LV.
The multipath target did not opt-in to supporting WRITE SAME. Please
try this patch.
From: Mike Snitzer <snitzer@redhat.com>
Subject: [PATCH] dm mpath: enable WRITE SAME support
There is no reason to disallow WRITE SAME support. As far as multipath
is concerned it is just another write request.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-mpath.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 51bb816..bdf26f5 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -907,6 +907,7 @@ static int multipath_ctr(struct dm_target *ti, unsigned int argc,
ti->num_flush_bios = 1;
ti->num_discard_bios = 1;
+ ti->num_write_same_bios = 1;
return 0;
--
1.7.1
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2013-05-01 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 4:07 BLKZEROOUT on dm devices Bharata B Rao
2013-04-30 16:32 ` [PATCH] dm table: fix logic bug in dm_table_supports_write_same [was: Re: BLKZEROOUT on dm devices] Mike Snitzer
2013-05-01 6:58 ` Bharata B Rao
2013-05-01 13:29 ` Mike Snitzer [this message]
2013-05-01 14:22 ` [PATCH] dm mpath: enable WRITE SAME support Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501132922.GA10432@redhat.com \
--to=snitzer@redhat.com \
--cc=bharata.rao@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.