From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1UXpMH-0001iW-0u
	for qemu-devel@nongnu.org; Thu, 02 May 2013 04:59:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1UXpMF-0004ul-IJ
	for qemu-devel@nongnu.org; Thu, 02 May 2013 04:59:20 -0400
Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:58040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1UXpMF-0004si-8k
	for qemu-devel@nongnu.org; Thu, 02 May 2013 04:59:19 -0400
Received: from /spool/local
	by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Thu, 2 May 2013 09:57:28 +0100
Received: from b06cxnps4074.portsmouth.uk.ibm.com
	(d06relay11.portsmouth.uk.ibm.com [9.149.109.196])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id BCB6B219005F
	for <qemu-devel@nongnu.org>; Thu,  2 May 2013 10:01:44 +0100 (BST)
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id r428x1I254001798
	for <qemu-devel@nongnu.org>; Thu, 2 May 2013 08:59:01 GMT
Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id r428x9Ew022898
	for <qemu-devel@nongnu.org>; Thu, 2 May 2013 02:59:10 -0600
Date: Thu, 2 May 2013 10:59:02 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20130502105902.09a823fe@gondolin>
In-Reply-To: <20130429200952.GA19286@redhat.com>
References: <517E9C71.1050300@greensocs.com>
	<20130429162106.GA10999@redhat.com>
	<20130429163055.GA11268@redhat.com>
	<517EA2A4.2030205@greensocs.com>
	<20130429170118.GA11497@redhat.com>
	<517EACA5.3090307@greensocs.com>
	<20130429175217.GA18172@redhat.com>
	<517EB590.9090700@greensocs.com>
	<20130429181533.GA18390@redhat.com>
	<517EBFDE.5090200@greensocs.com>
	<20130429200952.GA19286@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when
 calculating config_len
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: agraf@suse.de, aliguori@us.ibm.com, Jason Wang <jasowang@redhat.com>, Jesse Larrew <jlarrew@linux.vnet.ibm.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, KONRAD =?UTF-8?B?RnLDqWTDqXJpYw==?= <fred.konrad@greensocs.com>

On Mon, 29 Apr 2013 23:09:52 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Apr 29, 2013 at 08:45:50PM +0200, KONRAD Fr=C3=A9d=C3=A9ric wrote:

> > Maybe we can move the two firsts line in the virtio_net_pci_init before=
 the
> > init if they are usefull in the
> > config_size computing:
> >=20
> >=20
> >                 proxy->host_features |=3D 0x1 << VIRTIO_F_NOTIFY_ON_EMP=
TY;
> >                 proxy->host_features |=3D 0x1 << VIRTIO_F_BAD_FEATURE;
>=20
> Bus can set VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> later, this is not going to affect anything.
>=20
> Reason is, VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> are compatibility hacks which is why we dont
> have them for s390. It's probably a bug that
> we have them for virtio-ccw.
>=20

Yes, probably (I used virtio-pci as my inspiration a lot...)

I'll check whether killing this works as expected.