From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXpSC-0006f5-P2 for qemu-devel@nongnu.org; Thu, 02 May 2013 05:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXpPX-0006sY-Vj for qemu-devel@nongnu.org; Thu, 02 May 2013 05:02:45 -0400 Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:53873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXpPX-0006sE-Kt for qemu-devel@nongnu.org; Thu, 02 May 2013 05:02:43 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 May 2013 09:58:44 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 25F831B08019 for ; Thu, 2 May 2013 10:02:40 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4292UTo4194358 for ; Thu, 2 May 2013 09:02:30 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r4292daU024403 for ; Thu, 2 May 2013 03:02:39 -0600 Date: Thu, 2 May 2013 11:02:37 +0200 From: Cornelia Huck Message-ID: <20130502110237.50e47cf9@gondolin> In-Reply-To: <20130430090212.GA28253@redhat.com> References: <20130429163055.GA11268@redhat.com> <517EA2A4.2030205@greensocs.com> <20130429170118.GA11497@redhat.com> <517EACA5.3090307@greensocs.com> <20130429175217.GA18172@redhat.com> <517EB590.9090700@greensocs.com> <20130429181533.GA18390@redhat.com> <517EBFDE.5090200@greensocs.com> <20130429200952.GA19286@redhat.com> <517F8526.9070509@greensocs.com> <20130430090212.GA28253@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: agraf@suse.de, aliguori@us.ibm.com, Jason Wang , Jesse Larrew , Michael Roth , qemu-devel@nongnu.org, KONRAD =?UTF-8?B?RnLDqWTDqXJpYw==?= On Tue, 30 Apr 2013 12:02:12 +0300 "Michael S. Tsirkin" wrote: > On Tue, Apr 30, 2013 at 10:47:34AM +0200, KONRAD Fr=C3=A9d=C3=A9ric wrote: > > >>Then compute the last one directly in the init function which is the = harder: > > >> > > >> virtio_net_get_features > > >The real fix is to set features in init. > > > > > >Can we move host_features to struct VirtIODevice, and > > >init to the device init function? > > > > > >The reason we didn't do this initially is exactly > > >because we need to specify them in -device flag, > > >and there was no way to do this for VirtIODevice, > > >since it's the proxy that is instanciated. > > >Does the new bus infrastructure allow this? > >=20 > > Yes, I think it's possible for PCI and S390, but it seems more > > difficult for CCW. >=20 > Can you send the patch for pci to let everyone see what > you have in mind? The main issue is passing properties > from proxy to the device. Should probably not be hard to adapt to ccw. >=20 > > I don't really understand how it's working with CCW devices, there is an > > array of host_features? >=20 > In practice the array is of size 1. I'd suggest just assuming that for no= w. > When we extend features (which will happen pretty soon) > we'll do this for all transports and change features to uint64_t > everywhere. > After that, we'll have a bit of breathing space. Yes, the idea was to keep features easily extendable. Going 64 bit will work fine; the transport should be able to handle even larger features.