From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-omap@vger.kernel.org
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence
Date: Thu, 2 May 2013 14:37:27 +0200 [thread overview]
Message-ID: <20130502123727.GA17149@linutronix.de> (raw)
In-Reply-To: <1367495531-19470-1-git-send-email-mugunthanvnm@ti.com>
* Mugunthan V N | 2013-05-02 17:22:11 [+0530]:
>In CPSW NAPI, after processing all interrupts IRQ is enabled and then book
>keeping irq_enabled is updated. In random cases when a packet is transmitted
>or received between processing packets and IRQ enabled, then just after
>enabled IRQ and before irq_enabled is updated, ISR is called so IRQs are
>not disabled as irq_enabled is still false and CPU gets locked in CPSW ISR.
>
>By changing the sequence as update the irq_enabled and then enable IRQ
>fixes the issue. This issue is not captured always as it is a timing issue
>whether Tx or Rx IRQ is invoked between packet processing and enable IRQ.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2013-05-02 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 11:52 [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence Mugunthan V N
2013-05-02 11:52 ` Mugunthan V N
2013-05-02 12:37 ` Sebastian Andrzej Siewior [this message]
2013-05-02 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502123727.GA17149@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.