From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: Tegra: USB: Add driver support for Tegra30/Tegra114
Date: Thu, 2 May 2013 13:38:44 +0200 [thread overview]
Message-ID: <201305021338.44738.marex@denx.de> (raw)
In-Reply-To: <1367488229.13142.3.camel@jilin-desktop>
Dear Jim Lin,
[...]
> >
> > This is a problem with the struct-based access indeed. I agree with Tom
> > it'd be worth to at least try distilling the common part into header
> > shared between those three CPUs.
>
> OK. I will add this into next version of patch.
>
> > btw you're also adding some kernel-doc-alike annotations to functions,
> > why don't you follow kerneldoc style altogether?
>
> I don't understand what you meant here.
> Could you give me an example? Like what I did is wrong or not good. And
> what is correct or better one.
These kinds of annotations:
+/*
+ * Process a list of nodes, adding them to our list of SDMMC ports.
+ *
+ * @param blob fdt blob
+ * @param node_list list of nodes to process (any <=0 are ignored)
+ * @param count number of nodes to process
+ * @return 0 if ok, -1 on error
+ */
See http://www.denx.de/wiki/U-Boot/CodingStyle@the bottom for the right
style.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-02 11:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 9:21 [U-Boot] [PATCH 0/3] Tegra: USB: EHCI: add Tegra30 compatible support Jim Lin
2013-04-29 9:21 ` [U-Boot] [PATCH 1/3] ARM: Tegra: FDT: Add USB support for T20/T30/T114 Jim Lin
2013-05-02 19:10 ` Stephen Warren
2013-05-03 11:07 ` Jim Lin
2013-05-03 14:43 ` Stephen Warren
2013-05-03 11:48 ` Venu Byravarasu
2013-04-29 9:21 ` [U-Boot] [PATCH 2/3] ARM: Tegra: USB: Add driver support for Tegra30/Tegra114 Jim Lin
2013-04-29 23:46 ` Marek Vasut
2013-04-30 16:21 ` Tom Warren
2013-04-30 17:09 ` Marek Vasut
2013-04-30 17:20 ` Tom Rini
2013-05-01 16:16 ` Tom Warren
2013-05-01 16:45 ` Tom Rini
2013-05-01 19:33 ` Marek Vasut
2013-05-01 23:20 ` Tom Warren
2013-05-01 23:23 ` Tom Warren
2013-05-02 9:50 ` Jim Lin
2013-05-02 11:38 ` Marek Vasut [this message]
2013-05-02 15:38 ` Tom Warren
2013-05-02 19:29 ` Stephen Warren
2013-05-03 10:53 ` Jim Lin
2013-05-03 14:46 ` Stephen Warren
2013-04-29 9:21 ` [U-Boot] [PATCH 3/3] Tegra: Config: Enable Tegra30/Tegra114 USB function Jim Lin
2013-05-02 19:30 ` Stephen Warren
2013-05-03 15:02 ` [U-Boot] [PATCH 0/3] Tegra: USB: EHCI: add Tegra30 compatible support Stephen Warren
2013-05-08 16:11 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305021338.44738.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.