All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Philip J. Kelleher" <pjk1939@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, klebers@linux.vnet.ibm.com,
	brking@linux.vnet.ibm.com
Subject: Re: [PATCH 1/8] rsxx: Adding in debugfs entries.
Date: Thu, 2 May 2013 16:07:53 +0200	[thread overview]
Message-ID: <20130502140753.GS7800@kernel.dk> (raw)
In-Reply-To: <20130502140444.GA10306@oc6784271780.ibm.com>

On Thu, May 02 2013, Philip J. Kelleher wrote:
> On Thu, May 02, 2013 at 10:03:25AM +0200, Jens Axboe wrote:
> > On Wed, May 01 2013, Philip J. Kelleher wrote:
> > >  #define NO_LEGACY 0
> > > +#define DEBUGFS_NULL NULL
> > >  
> > > +static struct dentry *rsxx_debugfs_root = DEBUGFS_NULL;
> > 
> > What's the point of DEBUGFS_NULL?
> 
> Well, orginally, I had rsxx_debugfs_root initialized to NULL but
> the checkpatch script told me not to initialize directly with 0
> or NULL. So my solution is the #define macro.

Well, it's a static variable. The reason checkpatch tells you not to
initialize it to NULL/0 is because the bss is automatically zeroed.

-- 
Jens Axboe


  reply	other threads:[~2013-05-02 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02  0:23 [PATCH 1/8] rsxx: Adding in debugfs entries Philip J. Kelleher
2013-05-02  8:03 ` Jens Axboe
2013-05-02 14:04   ` Philip J. Kelleher
2013-05-02 14:07     ` Jens Axboe [this message]
2013-05-02 14:35       ` Philip J. Kelleher
  -- strict thread matches above, loose matches on Subject: below --
2013-05-28 21:08 Philip J. Kelleher
2013-05-29 18:18 ` Andy Shevchenko
2013-05-30 14:54   ` Philip J. Kelleher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502140753.GS7800@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=brking@linux.vnet.ibm.com \
    --cc=klebers@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjk1939@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.