All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV
Date: Thu, 2 May 2013 18:46:13 +0200	[thread overview]
Message-ID: <20130502164613.GE3206@jama> (raw)
In-Reply-To: <CAJTo0LZrk_JYXV8EQbJ9T__L6qBGHQfO5mNvZmUJtYTEas9x7g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Thu, May 02, 2013 at 05:11:28PM +0100, Burton, Ross wrote:
> On 2 May 2013 16:39, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> -PV = "0.10+git${SRCPV}"
> >> +PV = "0.10+git${SRCREV}"
> 
> As the git revision is the 0.10 tag, wouldn't it be clearer to not set
> PV as the git revision is a detail of the fetcher - this *is* 0.10.

That's fine too as long as nobody bumps SRCREV without updating PV or
uses AUTOREV from some .inc or local.conf.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-05-02 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 14:56 [PATCH v2 0/3] neard fixes Jukka Rissanen
2013-05-02 14:56 ` [PATCH v2 1/3] neard: Rename the recipe as we are already in 0.10 Jukka Rissanen
2013-05-02 14:56 ` [PATCH v2 2/3] neard: Use SRCREV instead of SRCPV Jukka Rissanen
2013-05-02 15:39   ` Martin Jansa
2013-05-02 16:11     ` Burton, Ross
2013-05-02 16:46       ` Martin Jansa [this message]
2013-05-03 15:36         ` Richard Purdie
2013-05-02 14:56 ` [PATCH v2 3/3] neard: Split recipe to two parts Jukka Rissanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502164613.GE3206@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.