From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/7] mx23: Fix pad voltage selection bit
Date: Fri, 3 May 2013 04:34:11 +0200 [thread overview]
Message-ID: <201305030434.11447.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKpkJ3+O-1MFKyvVWDx1X7UvC3YOw=per3vgyG3TG13S5A@mail.gmail.com>
Dear Otavio Salvador,
> On Thu, May 2, 2013 at 11:24 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Fabio Estevam,
> >
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> On mx23 the pad voltage selection bit needs to be always '0', since '1'
> >> is a reserved value.
> >>
> >> For example:
> >>
> >> Pin 108, EMI_A06 pin voltage selection:
> >> 0= 1.8V (mDDR) or 2.5V (DDR1);
> >> 1= reserved.
> >>
> >> Fix the pad voltage definitions for the mx23 case.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > but then, should we not just undefine this PAD_3V3 for MX23 altogether so
> > noone is tempted to use it?
>
> I think for code readability it'd be good to have it in place. It
> makes it more obvious for people looking at code.
I can already see the people wondering why that piece has no effect ...
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-03 2:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 22:44 [U-Boot] [PATCH v3 0/9] mx23: Make DDR initialization stable Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 1/7] mx23: Fix pad voltage selection bit Fabio Estevam
2013-05-03 2:24 ` Marek Vasut
2013-05-03 2:33 ` Otavio Salvador
2013-05-03 2:34 ` Marek Vasut [this message]
2013-05-03 2:34 ` Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 2/7] mx23evk: Fix DDR pin iomux settings Fabio Estevam
2013-05-03 2:24 ` Marek Vasut
2013-05-03 2:35 ` Fabio Estevam
2013-05-03 2:37 ` Marek Vasut
2013-05-03 2:51 ` Fabio Estevam
2013-05-03 3:22 ` Marek Vasut
2013-05-02 22:44 ` [U-Boot] [PATCH v3 3/7] mx23_olinuxino: " Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 4/7] mxs: spl_mem_init: Fix comment about start bit Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 5/7] mxs: spl_mem_init: Remove erroneous DDR setting Fabio Estevam
2013-05-03 2:25 ` Marek Vasut
2013-05-03 2:37 ` Fabio Estevam
2013-05-03 2:50 ` Marek Vasut
2013-05-02 22:44 ` [U-Boot] [PATCH v3 6/7] mxs: spl_mem_init: Skip the initialization of some DRAM_CTL registers Fabio Estevam
2013-05-03 2:26 ` Marek Vasut
2013-05-03 2:33 ` Otavio Salvador
2013-05-02 22:44 ` [U-Boot] [PATCH v3 7/7] mxs: spl_mem_init: Change EMI port priority Fabio Estevam
2013-05-03 2:20 ` [U-Boot] [PATCH v3 0/9] mx23: Make DDR initialization stable Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305030434.11447.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.