Re: [PATCH v2] xen: handle paged gfn in wrmsr_hypervisor_regs

[Olaf Hering <olaf@aepfle.de>]

On Fri, May 03, Jan Beulich wrote:

> >>> On 03.05.13 at 14:57, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -1682,14 +1682,25 @@ static int svm_msr_write_intercept(unsig
> >          if ( wrmsr_viridian_regs(msr, msr_content) )
> >              break;
> >  
> > -        wrmsr_hypervisor_regs(msr, msr_content);
> > +        ret = wrmsr_hypervisor_regs(msr, msr_content);
> > +        switch ( ret )
> > +        {
> > +            case -EAGAIN:
> > +                result = X86EMUL_RETRY;
> > +                break;
> > +            case 0:
> > +                result = X86EMUL_UNHANDLEABLE;
> > +                break;
> > +            default:
> > +                break;
> 
> As you had already noticed the hard way - case 0 and default of
> course need to be switched (0 -> okay, anything else ->
> unhandleable).

I dont follow.
ret == 1 looks like success to me, ret == 0 some sort of failure.


Olaf