From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v2] xen: handle paged gfn in
 wrmsr_hypervisor_regs
Date: Fri, 3 May 2013 17:19:13 +0200
Message-ID: <20130503151913.GA29247@aepfle.de>
References: <5183DEBE02000078000D31BB@nat28.tlf.novell.com>
	<CDA987C1.23FA6%keir.xen@gmail.com>
	<5183E64F02000078000D322E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <5183E64F02000078000D322E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir.xen@gmail.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, May 03, Jan Beulich wrote:

> >>> On 03.05.13 at 16:26, Keir Fraser <keir.xen@gmail.com> wrote:
> > I suggest the following return codes:
> >  0: not handled
> >  1: handled
> >  -EINVAL: error during handling
> >  -EAGAIN: retry
> > 
> > The HVM callers should then handle as follows:
> >  -EAGAIN: rc = X86EMUL_RETRY
> >  -EINVAL: goto gp_fault
> >  0: try other msr handlers (if any)
> >  1: we're done, return X86EMUL_OKAY
> > 
> > Does that make sense?
> 
> Sure - you may have seen my later reply where I also notide
> this mistake in my first response to Olaf.

I sent v3 of the patch. I had to guess which 'return 0' is supposed to
be an error.

Olaf