From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH v2] drm/i915: unreference default context on module unload Date: Fri, 3 May 2013 08:53:20 -0700 Message-ID: <20130503155230.GA24646@bwidawsk.net> References: <20130502161016.GB2641@bwidawsk.net> <1367587748-643-1-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 992CDE5CFC for ; Fri, 3 May 2013 08:50:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367587748-643-1-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org On Fri, May 03, 2013 at 04:29:08PM +0300, Mika Kuoppala wrote: > Before module unload is called, gpu_idle() will switch > to default context. This will increment ref count of base > object as the default context is 'running' on module unload > time. Unreference the drm object so that when context > is freed, base object is freed as well. > > v2: added comment to explain the refcounts (Ben Widawsky) > > Signed-off-by: Mika Kuoppala I left an r-b on the other patch. You should feel free to add it if you actually do what I say. Reviewed-by: Ben Widawsky [snip] -- Ben Widawsky, Intel Open Source Technology Center