From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v2] drm/i915: unreference default context on
 module unload
Date: Fri, 3 May 2013 18:22:49 +0200
Message-ID: <20130503162249.GO5763@phenom.ffwll.local>
References: <20130502161016.GB2641@bwidawsk.net>
	<1367587748-643-1-git-send-email-mika.kuoppala@intel.com>
	<20130503155230.GA24646@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
	[209.85.212.180])
	by gabe.freedesktop.org (Postfix) with ESMTP id B736AE64D1
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  3 May 2013 09:19:44 -0700 (PDT)
Received: by mail-wi0-f180.google.com with SMTP id h11so791200wiv.1
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 03 May 2013 09:19:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130503155230.GA24646@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
List-Id: intel-gfx@lists.freedesktop.org

On Fri, May 03, 2013 at 08:53:20AM -0700, Ben Widawsky wrote:
> On Fri, May 03, 2013 at 04:29:08PM +0300, Mika Kuoppala wrote:
> > Before module unload is called, gpu_idle() will switch
> > to default context. This will increment ref count of base
> > object as the default context is 'running' on module unload
> > time. Unreference the drm object so that when context
> > is freed, base object is freed as well.
> > 
> > v2: added comment to explain the refcounts (Ben Widawsky)
> > 
> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> 
> I left an r-b on the other patch. You should feel free to add it if you
> actually do what I say.
> 
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch