All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Zhang, Hao" <hzhang@ti.com>
Cc: meta-arago@arago-project.org, "Karicheri,
	Muralidharan" <m-karicheri2@ti.com>
Subject: Re: MCSDK rootfs boot directory
Date: Fri, 3 May 2013 12:28:20 -0400	[thread overview]
Message-ID: <20130503162820.GE9213@edge> (raw)
In-Reply-To: <ECA334CFBA16F74DB2C66A2F1181F4D63C2B4A6E@DLEE09.ent.ti.com>

Hao,

The rule is to use the same exact directory structure for .bbappend in our 
layer, as the original .bb recipe in the original layer. Also, it has to have 
the proper version in the name. So, check where the original oprofile recipe 
is located (oe-core/meta/recipes-kernel/oprofile), which version you are using 
(0.9.7) and that will give you the .bbappend name and location:

meta-arago/meta-arago-distro/recipes-kernel/oprofile/oprofile_0.9.7.bbappend

As the name suggests, this file is "appended" to the original recipe, so you 
have a way to overwrite or change anything that is set in the original recipe:

PR_append = "-arago0"
RRECOMMENDS_${PN} = ""

The first line is to update the PR and indicate it has been arago-modified.

PS. This is exactly why this kind of discussion shouldn't be done in private, 
as I keep explaining about bbappend to your team-mates over and over again. 
I'm copying it to meta-arago list, which your team members should be already 
subscribed to.

PS2. And if later you would like to submit this to meta-arago, I'd suggest 
making it conditional for your platform, so others would still get the 
original behaviour:

PR_append = "-arago0"
KERNELIMAGE = "kernel-vmlinux"
KERNELIMAGE_keystone = ""
RRECOMMENDS_${PN} = "${KERNELIMAGE}"

-- 
Denys


On Fri, May 03, 2013 at 11:58:03AM -0400, Zhang, Hao wrote:
> Denys,
> 
> Can you suggest in which directory should I add oprofile.bbappend? Should I 
> add it under meta-arago/meta-arago-distro/recipes-core/oprofile/ 
> oprofile.bbappend? And what is the oprofile version should I use?
> 
> On Fri, May 03, 2013 at 11:42:12AM -0400, Karicheri, Muralidharan wrote:
> > Denys,
> > 
> > So the documentation should state the vmlinux should be copied to the 
> > boot folder of root fs to work with oprofile, right?
> > 
> > >> On Thu, May 02, 2013 at 06:47:23PM -0400, Karicheri, Muralidharan wrote:
> > >> > Is there a way we can still keep oprofile in the Linux? User 
> > >> > should be able to copy vmlinux manually and still use oprofile, right?
> > >> 
> > >> Make a .bbappend for oprofile, and put this in:
> > >> 
> > >> RRECOMMENDS_${PN} = ""
> > >> 
> > >> That will stop it from pulling vmlinux, but make sure you document it 
> > >> for users...


           reply	other threads:[~2013-05-03 16:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <ECA334CFBA16F74DB2C66A2F1181F4D63C2B4A6E@DLEE09.ent.ti.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130503162820.GE9213@edge \
    --to=denys@ti.com \
    --cc=hzhang@ti.com \
    --cc=m-karicheri2@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.