Re: [PATCH] added mounting debugfs recipe

[Denys Dmytriyenko <denys@ti.com>]

On Fri, May 03, 2013 at 04:22:59PM +0000, Maupin, Chase wrote:
> > Hey Chase, thanks for the comments. Here's the patch.
> > 
> > From a1684ac257292855c03e58f3fee60232ed039b81 Mon Sep 17 00:00:00
> > 2001
> > From: Jingting Zhou <a0221004@ares-ubuntu>

^^^^


> > Date: Fri, 3 May 2013 11:56:05 -0400
> > Subject: [PATCH] using inherit update-rc.d in the initscript-
> > debugfs recipe
> 
> 
> You need to use a proper commit message here.  See 
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Correct. Also make sure your From line is valid. Please configure your git 
properly - git-config.


> This should probably be squashed with the commit that adds the recipe

Heh, and this time it's a patch over patch on top of a patch... :) Don't do 
this, send a version 3 of the original patch.


> > diff --git a/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes-
> > bsp/initscript-debugfs/initscript-debugfs.bb
> > index eaf316a..0137214 100755
> > --- a/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb
> > +++ b/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb
> > @@ -1,18 +1,20 @@
> >  DESCRIPTION = "Initscripts for debugfs"
> >  LICENSE = "BSD"
> > 
> > -LIC_FILES_CHKSUM =
> > "file://LICENSE;md5=3c1998754d846b48ba935ea0b7ada19a"
> > +LIC_FILES_CHKSUM =
> > "file://debugfs.sh;md5=a530203f3f8bf332686f4abf1e434e21"
> 
> Do your checksum of only the license lines.  This prevents a script change 
> from changing your license checksum.  Like 
> meta-ti/recipes-connectivity/uim/uim_git.bb.  Notice the startline and end 
> line fields.

I'd suggest initscript-telnetd here again :)


> >  PR ="r0"
> > 
> > -SRC_URI = "file://debugfs.sh \
> > -		   file://LICENSE"
> > +SRC_URI = "file://debugfs.sh"
> > +
> > +INITSCRIPT_NAME = "debugfs.sh"
> > +INITSCRIPT_PARAMS = "defaults 10"
> > +
> > +inherit update-rc.d
> > 
> >  S = "${WORKDIR}"
> > 
> >  do_install () {
> > -	install -d ${D}${sysconfdir}/init.d/
> > -	install -d ${D}${sysconfdir}/rcS.d/
> > -	install -c -m 755 ${WORKDIR}/debugfs.sh
> > ${D}${sysconfdir}/init.d/debugfs.sh
> > -	ln -sf ../init.d/debugfs.sh
> > ${D}${sysconfdir}/rcS.d/S09debugfs
> > +	install -d ${D}${sysconfdir}/init.d/
> > +	install -c -m 755 ${WORKDIR}/debugfs.sh
> > ${D}${sysconfdir}/init.d/debugfs.sh
> 
> Just a nitpick but there is no need to specify debugfs.sh in the destination 
> path.  Also, most init scripts don't bother with the .sh extension.  BTW, 
> using "defaults" for update-rc.d will put this script in run levels 2345.  
> If you want it in rcS then you need to change your INITSCRIPT_PARAMS 
> setting.  Do a man of update-rc.d to find out how that utility works.

Learning on update-rc.d in general is beneficial for you and your future 
recipes, so you may want to allocate some "training" time for that.

And for now the quickest approach would be to just copy the usage from 
initscript-telnetd - it is after all a very similar initscript...

-- 
Denys