From: Jens Axboe <axboe@kernel.dk>
To: Michel Jansens <michel.jansens@ulb.ac.be>
Cc: fio@vger.kernel.org
Subject: Re: random read generates zero filled file
Date: Fri, 3 May 2013 19:38:26 +0200 [thread overview]
Message-ID: <20130503173826.GX7800@kernel.dk> (raw)
In-Reply-To: <20130503100839.GI7800@kernel.dk>
On Fri, May 03 2013, Jens Axboe wrote:
> On Fri, May 03 2013, Michel Jansens wrote:
> > Hi,
> >
> > I'm trying out FIO, and rand a random read job with a 12GB file. It
> > seems that the "Laying out IO file(s) " process generates a
> > zero-filled file. This means that when compression is activated (on
> > ZFS), no reads actually happens.
> >
> > I tried adding a "buffer_compress_percentage=10" section to tell
> > generated data should compress from only "10%" but this seems to apply
> > only to actual benchmark job, not the 'laying out file's.
> >
> > Am I missing something?
>
> No, it currently just fills zeroes. It's trivial to make it honor the
> usual buffer fill logic, though. With the below patch, it'll do what fio
> otherwise would have done to IO buffers during the benchmark run.
Since the followups didn't make it here, the below exposed a bug in the
compression logic where it would loop infinitely if compress_chunk
wasn't set too.
So we got a new feature, and a fix for an older bug as well. Commit is
here:
http://git.kernel.dk/?p=fio.git;a=commit;h=cc86c395fd9dd2002ec1edc0967b7c9453debdfb
--
Jens Axboe
next prev parent reply other threads:[~2013-05-03 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 8:58 random read generates zero filled file Michel Jansens
2013-05-03 10:08 ` Jens Axboe
2013-05-03 17:38 ` Jens Axboe [this message]
2013-05-03 19:44 ` Michel Jansens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503173826.GX7800@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=michel.jansens@ulb.ac.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.