All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] add daemon mode support to pulseaudio
Date: Fri, 3 May 2013 19:33:53 +0200	[thread overview]
Message-ID: <20130503193353.1672f8dd@skate> (raw)
In-Reply-To: <1367584523-8491-1-git-send-email-jeremy.rosen@openwide.fr>

Dear J?r?my Rosen,

The title of the patch should be:

	pulseaudio: add daemon mode support

i.e, always put the name of the affected package first.

On Fri,  3 May 2013 14:35:22 +0200, J?r?my Rosen wrote:
> pulseaudio documentation recommands not using the daemon mode unless you

recommends.

> are on a headless system, but since that is the common case for a
> buildroot installation, install the related user and groups

> +config BR2_PACKAGE_PULSEAUDIO_DAEMON
> +	bool "start pulseaudio as a system daemon"

	bool "start as a daemon"

should be sufficient, since the option will be indented under
pulseaudio.

> +	depends on BR2_PACKAGE_PULSEAUDIO
> +	help
> +	  PulseAudio can be started as a system daemon. This is not the
> +	  recommanded way of using PulseAudio unless you are building a

recommended.

> +	  headless system

Missing final dot. It would be good to explain how pulseaudio is
started when this option is not selected.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-03 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 12:35 [Buildroot] [PATCH 1/1] add daemon mode support to pulseaudio Jérémy Rosen
2013-05-03 17:33 ` Thomas Petazzoni [this message]
2013-05-04 15:16 ` Peter Korsgaard
2013-05-06  8:17   ` Jeremy Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130503193353.1672f8dd@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.