From: Al Viro <viro@ZenIV.linux.org.uk>
To: Michael Leun <lkml20130126@newton.leun.net>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [REGRESSION] bisected: 3.8 -> 3.9 cannot umount after using fuse
Date: Sat, 4 May 2013 16:52:14 +0100 [thread overview]
Message-ID: <20130504155214.GD25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130504124519.032ac684@xenia.leun.net>
On Sat, May 04, 2013 at 12:45:19PM +0200, Michael Leun wrote:
> After reverting 57eccb830f1cc93d4b506ba306d8dfa685e0c88f from 3.9 that
> umount above works (not busy).
Sigh... Check if the following fix works for your testcase:
diff --git a/fs/namespace.c b/fs/namespace.c
index b4f96a5..b68eef2d 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2284,12 +2284,11 @@ long do_mount(const char *dev_name, const char *dir_name,
retval = security_sb_mount(dev_name, &path,
type_page, flags, data_page);
+ if (!retval && !may_mount())
+ retval = -EPERM;
if (retval)
goto dput_out;
- if (!may_mount())
- return -EPERM;
-
/* Default to relatime unless overriden */
if (!(flags & MS_NOATIME))
mnt_flags |= MNT_RELATIME;
next prev parent reply other threads:[~2013-05-04 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-04 10:45 [REGRESSION] bisected: 3.8 -> 3.9 cannot umount after using fuse Michael Leun
2013-05-04 15:52 ` Al Viro [this message]
2013-05-04 18:02 ` Michael Leun
2013-05-04 18:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130504155214.GD25399@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml20130126@newton.leun.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.