All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 3/9] Input: gpio_tilt_polled - Remove redundant platform_set_drvdata()
Date: Sat, 4 May 2013 21:44:48 +0200	[thread overview]
Message-ID: <201305042144.50286.heiko@sntech.de> (raw)
In-Reply-To: <1367679118-2980-3-git-send-email-sachin.kamat@linaro.org>

Am Samstag, 4. Mai 2013, 16:51:52 schrieb Sachin Kamat:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>

not sure, if it's needed for such a small change, but nevertheless
Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/input/misc/gpio_tilt_polled.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/gpio_tilt_polled.c
> b/drivers/input/misc/gpio_tilt_polled.c index da05cca..714c683 100644
> --- a/drivers/input/misc/gpio_tilt_polled.c
> +++ b/drivers/input/misc/gpio_tilt_polled.c
> @@ -184,8 +184,6 @@ static int gpio_tilt_polled_remove(struct
> platform_device *pdev) struct gpio_tilt_polled_dev *tdev =
> platform_get_drvdata(pdev);
>  	const struct gpio_tilt_platform_data *pdata = tdev->pdata;
> 
> -	platform_set_drvdata(pdev, NULL);
> -
>  	input_unregister_polled_device(tdev->poll_dev);
>  	input_free_polled_device(tdev->poll_dev);


  reply	other threads:[~2013-05-04 19:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-04 14:51 [PATCH 1/9] Input: ab8500-ponkey - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-04 14:51 ` [PATCH 2/9] Input: bfin_rotary " Sachin Kamat
2013-05-04 14:51 ` [PATCH 3/9] Input: gpio_tilt_polled " Sachin Kamat
2013-05-04 19:44   ` Heiko Stübner [this message]
2013-05-04 14:51 ` [PATCH 4/9] Input: max8925_onkey " Sachin Kamat
2013-05-04 14:51 ` [PATCH 5/9] Input: mc13783-pwrbutton " Sachin Kamat
2013-05-04 14:51 ` [PATCH 6/9] Input: pm8xxx-vibrator " Sachin Kamat
2013-05-04 14:51 ` [PATCH 7/9] Input: pmic8xxx-pwrkey " Sachin Kamat
2013-05-04 14:51 ` [PATCH 8/9] Input: pwm-beeper " Sachin Kamat
2013-05-04 14:51 ` [PATCH 9/9] Input: rotary_encoder " Sachin Kamat
2013-05-06 10:12   ` Daniel Mack
2013-05-06  3:01 ` [PATCH 1/9] Input: ab8500-ponkey " Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305042144.50286.heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.