From: Adrien Mazarguil <adrien.mazarguil-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] app: fix refcnt in mbuf allocation
Date: Mon, 6 May 2013 15:56:16 +0200 [thread overview]
Message-ID: <20130506135616.GN12221@6wind.com> (raw)
In-Reply-To: <CAAYH+dX-n2vbZh8P-by0Vk-sPn-E+ZSTMx1HJnKiHXgh-5G+wQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi all (replying below)
On Mon, May 06, 2013 at 09:28:33AM -0400, Han, Dongsu wrote:
> Sounds good. With the two bug fixes I submitted txonly now runs perfectly.
> Thanks!
> -Dongsu
> On May 6, 2013 8:47 AM, "Thomas Monjalon" <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:
>
> > Hi Dongsu Han,
> >
> > I think your fix is right.
> > I've just removed tx_mbuf_alloc() and directly called rte_pktmbuf_alloc()
> > instead.
> > Is it OK for you ?
> > Could you also review this (modified) description ?
[...]
While using rte_pktmbuf_alloc() is the correct fix, it's much slower than
__rte_mbuf_raw_alloc() due to the unnecessary call to rte_pktmbuf_reset().
Since testpmd is often used for performance testing, we should consider a
wrapper function calling __rte_mbuf_raw_alloc() directly instead, as in
rte_rxmbuf_alloc() implemented in igb and ixgbe PMDs.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2013-05-06 13:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 14:24 suggested patch: testpmd txonly mbuf_alloc does not increment refcnt Han, Dongsu
[not found] ` <CAAYH+dW3RenDv9=dn0Mtdubp0443OWqAqPYfHjGKfQcjQHNgxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-06 12:47 ` [PATCH] app: fix refcnt in mbuf allocation Thomas Monjalon
[not found] ` <1367844470-15346-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-06 13:28 ` Han, Dongsu
[not found] ` <CAAYH+dX-n2vbZh8P-by0Vk-sPn-E+ZSTMx1HJnKiHXgh-5G+wQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-06 13:56 ` Adrien Mazarguil [this message]
[not found] ` <20130506135616.GN12221-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-06 15:47 ` Han, Dongsu
[not found] ` <CAAYH+dWnQ_eP-evFv2ABL8s==Oq1VB0secy1Dj4ZH9BA6ac9wA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-06 16:13 ` Thomas Monjalon
2013-05-06 16:00 ` [PATCH] " Thomas Monjalon
[not found] ` <1367856001-25036-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-06 16:13 ` Adrien Mazarguil
[not found] ` <20130506161334.GO12221-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-05-06 16:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506135616.GN12221@6wind.com \
--to=adrien.mazarguil-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.