From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMuF-0007Q8-Uq for qemu-devel@nongnu.org; Mon, 06 May 2013 11:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZMuC-0000Ln-Q6 for qemu-devel@nongnu.org; Mon, 06 May 2013 11:00:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMuC-0000LT-E0 for qemu-devel@nongnu.org; Mon, 06 May 2013 11:00:44 -0400 Date: Mon, 6 May 2013 18:00:27 +0300 From: "Michael S. Tsirkin" Message-ID: <20130506150027.GA22689@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH for-1.5] virtio-pci: bugfix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Anthony Liguori , "Michael S. Tsirkin" , KONRAD Frederic mask notifiers are never called without msix, so devices with backend masking like vhost don't work. Call mask notifiers explicitly at startup/cleanup to make it work. Signed-off-by: Michael S. Tsirkin Tested-by: Alexander Graf --- hw/virtio/virtio-pci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 8bba0f3..d0fcc6c 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -758,6 +758,10 @@ static int virtio_pci_set_guest_notifier(DeviceState *d, int n, bool assign, event_notifier_cleanup(notifier); } + if (!msix_enabled(&proxy->pci_dev) && proxy->vdev->guest_notifier_mask) { + proxy->vdev->guest_notifier_mask(proxy->vdev, n, !assign); + } + return 0; } -- MST