All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Colin Cross <ccross@android.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mandeep Singh Baines <msb@chromium.org>,
	Paul Walmsley <paul@pwsan.com>, Al Viro <viro@zeniv.linux.org.uk>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Oleg Nesterov <oleg@redhat.com>,
	linux-nfs <linux-nfs@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ben Chan <benchan@chromium.org>
Subject: Re: [PATCH 2/2] lockdep: check that no locks held at freeze time
Date: Mon, 6 May 2013 12:33:07 -0700	[thread overview]
Message-ID: <20130506193307.GD800@mtj.dyndns.org> (raw)
In-Reply-To: <CAMbhsRRcfpXBGAPThjrmB_judgn85TioR_6A6qwh_fBQCent7A@mail.gmail.com>

Hello,

On Mon, May 06, 2013 at 12:30:19PM -0700, Colin Cross wrote:
> > I don't care about %current change, especially given that it's a debug
> > interface but that really should be a separate patch, so please split
> > it out if you want it (and I think we want it).
> 
> The current change was requested by akpm and was part of the original
> patch.  Is it really worth confusing the history of this patch even
> more, applying it the first time, reverting it, and then applying it
> again in two parts?

I don't know.  The patch seems confusing to me.  It really is about
adding single lockdep annotation but comes with other changes.  I
don't think it's a big deal either way but at least we wouldn't be
having this %current vs. @tsk conversation which is mostly irrelevant
to the actual proposed change, right?  It really should have been a
separate patch from the beginning.  Just refer to the original commit
and explain what happened?

Thanks.

-- 
tejun

  reply	other threads:[~2013-05-06 19:33 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 21:04 [PATCH 1/2] freezer: add unsafe versions of freezable helpers Colin Cross
2013-05-03 21:04 ` [PATCH 2/2] lockdep: check that no locks held at freeze time Colin Cross
2013-05-04 13:04   ` Pavel Machek
2013-05-04 13:04     ` Pavel Machek
2013-05-04 20:27     ` Colin Cross
2013-05-04 22:57       ` Pavel Machek
2013-05-04 23:49         ` Colin Cross
2013-05-04 23:49           ` Colin Cross
2013-05-05  0:05           ` Pavel Machek
2013-05-05  0:23             ` Colin Cross
2013-05-05  0:23               ` Colin Cross
2013-05-05  1:13               ` Pavel Machek
2013-05-05  1:13                 ` Pavel Machek
2013-05-05  9:18             ` Ingo Molnar
2013-05-05  9:18               ` Ingo Molnar
2013-05-06  8:55               ` Peter Zijlstra
2013-05-06  8:55                 ` Peter Zijlstra
2013-05-06 12:11                 ` Pavel Machek
2013-05-06 14:33                 ` Linus Torvalds
2013-05-06 14:42                   ` Peter Zijlstra
2013-05-06 19:01   ` Tejun Heo
2013-05-06 19:01     ` Tejun Heo
2013-05-06 19:30     ` Colin Cross
2013-05-06 19:33       ` Tejun Heo [this message]
2013-05-06 20:06         ` Rafael J. Wysocki
2013-05-04 13:00 ` [PATCH 1/2] freezer: add unsafe versions of freezable helpers Pavel Machek
2013-05-04 20:23   ` Colin Cross
2013-05-04 22:55     ` Pavel Machek
2013-05-04 22:55       ` Pavel Machek
2013-05-05  9:23 ` Ingo Molnar
2013-05-05 22:12   ` Pavel Machek
2013-05-05 22:12     ` Pavel Machek
2013-05-06  8:50 ` Peter Zijlstra
2013-05-06  8:50   ` Peter Zijlstra
2013-05-06 10:58   ` Jeff Layton
2013-05-06 10:56 ` Jeff Layton
2013-05-06 19:57   ` Colin Cross
2013-05-06 21:43     ` Jeff Layton
2013-05-06 21:43       ` Jeff Layton
2013-05-06 21:54       ` Colin Cross
2013-05-06 21:54         ` Colin Cross
2013-05-06 21:58         ` Linus Torvalds
2013-05-06 22:05           ` Jeff Layton
2013-05-06 22:11           ` Colin Cross
2013-05-06 22:14           ` Tejun Heo
2013-05-06 21:59         ` Jeff Layton
2013-05-06 18:55 ` Tejun Heo
2013-05-06 18:55   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130506193307.GD800@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=akpm@linux-foundation.org \
    --cc=benchan@chromium.org \
    --cc=bfields@fieldses.org \
    --cc=ccross@android.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=msb@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paul@pwsan.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.