From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by arago-project.org (Postfix) with ESMTPS id 0622052A98 for ; Mon, 6 May 2013 22:30:57 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r46MUvHL030221 for ; Mon, 6 May 2013 17:30:57 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r46MUvnj011618 for ; Mon, 6 May 2013 17:30:57 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Mon, 6 May 2013 17:30:56 -0500 Received: from localhost ([158.218.102.158]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r46MUupJ019381; Mon, 6 May 2013 17:30:56 -0500 Date: Mon, 6 May 2013 18:30:56 -0400 From: Denys Dmytriyenko To: "Cooper Jr., Franklin" Message-ID: <20130506223056.GE10607@edge> References: <1367875806-8694-1-git-send-email-fcooper@ti.com> <20130506213151.GB10607@edge> <8F29D6B095ED194EA1980491A5E029710C44AC4E@DFLE08.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C44AC4E@DFLE08.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2013 22:30:58 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, May 06, 2013 4:32 PM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > > ARM9 SOCs > > > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > > > * Linaro toolchain does not support ARM9 architecture. > > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > > > Signed-off-by: Franklin S. Cooper Jr > > > --- > > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > b/meta-arago-distro/conf/distro/arago.conf > > > index 3954360..048c480 100644 > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda > > > largefile pcmcia usbgadget usbh > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > local.conf # Set some sane defaults, in case someone forgets to set > > > them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > +# ARM9 is not supported by the Linaro toolchain so default back to > > > +the Arago # toolchain for ARM9 based SOCs. > > > +TOOLCHAIN_BRAND ?= > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > I don't feel this belongs in the arago.conf - as the comment above says, this is > > supposed to be set in the local.conf anyways, here it just offers a default fall > > back... > > I don't see what harm is done by tweaking the variable to insure an optimal > and safe default fall back is provided for all platforms we support. This > patch changes nothing except fixes a broken use case. Overhead - it calls that Python function every time you evaluate TOOLCHAIN_BRAND variable... I might be more lenient with something like this though: TC_SANEDEFAULT := "${@...}" TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" Although, that would no longer work in local.conf, only arago.conf... -- Denys