From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] perf, x86: Don't allow unusual PEBS raw flags
Date: Tue, 7 May 2013 10:48:03 +0200 [thread overview]
Message-ID: <20130507084803.GD9688@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <20130507064804.GE17705@gmail.com>
On Tue, May 07, 2013 at 08:48:05AM +0200, Ingo Molnar wrote:
> Also, this code only runs when the event is set up, so a bit of sanity
> checking can only help, right?
Nah, its all very circumspect. In fact; while what Andi states is 'true':
> documentation in the Intel SDM 18.6.1.1 states:
>
> """
> PEBS events are only valid when the following fields of IA32_PERFEVTSELx are all
> zero: AnyThread, Edge, Invert, CMask.
> """
It is also true that Intel themselves gave us events that contradict this; look
at the intel_pebs_aliases*() functions.
This patch would make it impossible to manually create those events.
Further, there's something entirely different behind this.
next prev parent reply other threads:[~2013-05-07 8:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 23:04 [PATCH 1/2] Fix perf LBR filtering Andi Kleen
2013-04-24 23:04 ` [PATCH 2/2] perf, x86: Don't allow unusual PEBS raw flags Andi Kleen
2013-04-29 22:16 ` Stephane Eranian
2013-04-29 22:34 ` Andi Kleen
2013-04-29 23:05 ` Stephane Eranian
2013-05-02 7:37 ` Peter Zijlstra
2013-05-06 17:44 ` Stephane Eranian
2013-05-06 18:52 ` Peter Zijlstra
2013-05-06 22:43 ` Stephane Eranian
2013-05-07 6:48 ` Ingo Molnar
2013-05-07 8:48 ` Peter Zijlstra [this message]
2013-05-07 11:04 ` Ingo Molnar
2013-05-07 8:43 ` Peter Zijlstra
2013-04-24 23:20 ` [PATCH 1/2] Fix perf LBR filtering Ben Hutchings
2013-04-24 23:24 ` Greg KH
2013-04-25 16:25 ` Peter Zijlstra
2013-04-25 16:41 ` Andi Kleen
2013-04-25 16:48 ` Peter Zijlstra
2013-04-25 17:00 ` Andi Kleen
2013-04-25 17:18 ` Peter Zijlstra
2013-04-25 17:42 ` Andi Kleen
2013-04-26 7:56 ` Peter Zijlstra
2013-04-26 19:46 ` Andi Kleen
2013-05-01 11:51 ` Ingo Molnar
2013-05-01 11:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507084803.GD9688@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.