From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 01/12] toolchain/gcc: Add host-{flex, bison} dependencies for GCC 4.2, 4.3, 4.4
Date: Tue, 7 May 2013 09:54:48 +0200 [thread overview]
Message-ID: <20130507095448.765b8cc4@skate> (raw)
In-Reply-To: <87wqreqx77.fsf@dell.be.48ers.dk>
Dear Peter Korsgaard,
On Sat, 04 May 2013 22:58:20 +0200, Peter Korsgaard wrote:
> Mischa> +ifneq ($(findstring x4.2.,x$(GCC_VERSION)),x4.2.)
> Mischa> +ifneq ($(findstring x4.3.,x$(GCC_VERSION)),x4.3.)
> Mischa> +ifneq ($(findstring x4.4.,x$(GCC_VERSION)),x4.4.)
> Mischa> +GCC_HOST_PREREQ = host-flex host-bison
>
> Ehh, two things:
>
> - This implements the opposite logic of what the commit message says
> (E.G. adds flex/bison if the version ISN'T 4.2/4.3/4.4)
>
> - It overrides GCC_HOST_PREREQ instead of appending to it even though
> the line just above already appends something.
Hum, right. Mischa, could you fix those and submit a patch? I've added
a ARC configuration to the autobuilders, and it is now failing since
Peter didn't commit this patch.
> It isn't clear to me what the gcc version logic should be, and if it is
> somehow related to ARC - I don't recall any autobuilder failures
> regarding missing flex/bison.
The problem is that those old gcc versions require flex/bison to build
properly. The issue was not seen on the autobuilders, because so far the
only architectures that are using those old versions are AVR32 (4.2)
and SPARC/Leon (4.4).
For AVR32, the autobuilder uses a an external toolchain which was built
with a previous version of Buildroot, at a time where the autobuilder
chroot had bison and flex installed system-wide.
For SPARC, there is no autobuilder configuration (maybe I should add
one?).
So this bug already exists today, independently of the ARC support: I
think that if you try to build the AVR32 internal toolchain on a system
where bison and flex are not installed, the build is going to fail.
See
http://autobuild.buildroot.org/results/cc6c6f8036ee2a35c3eec36cf3f4338e76c19d68/build-end.log
for an autobuilder failure that exhibits the problem.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-07 7:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 19:51 [Buildroot] [PATCH v4 00/12] ARC port Mischa Jonker
2013-05-02 19:51 ` [Buildroot] [PATCH v4 01/12] toolchain/gcc: Add host-{flex, bison} dependencies for GCC 4.2, 4.3, 4.4 Mischa Jonker
2013-05-04 20:58 ` Peter Korsgaard
2013-05-07 7:54 ` Thomas Petazzoni [this message]
2013-05-02 19:51 ` [Buildroot] [PATCH v4 02/12] arc: Add ARC and ARC BE architecture Mischa Jonker
2013-05-04 21:02 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 03/12] arc: Add option for ARC-specific download site Mischa Jonker
2013-05-04 21:04 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 04/12] arc: Add support for ARC-specific binutils Mischa Jonker
2013-05-04 21:08 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 05/12] arc: disable Crosstool-NG for ARC Mischa Jonker
2013-05-04 21:09 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 06/12] arc: add gcc " Mischa Jonker
2013-05-04 21:11 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 07/12] arc: Add support for ARC-specific uClibc Mischa Jonker
2013-05-04 21:21 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 08/12] arc: Make sure that libgcc doesn't get included when it doesn't exist yet Mischa Jonker
2013-05-04 21:22 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 09/12] toolchain/gcc: Only enable --with-float when it makes sense Mischa Jonker
2013-05-04 21:22 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 10/12] toolchain/toolchain-buildroot: Disable NPTL for ARC Mischa Jonker
2013-05-04 21:23 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 11/12] arc: Add arc, arcbe to gnuconfig Mischa Jonker
2013-05-04 21:23 ` Peter Korsgaard
2013-05-02 19:51 ` [Buildroot] [PATCH v4 12/12] kernel-headers: Add support for ARC kernel headers Mischa Jonker
2013-05-04 21:24 ` Peter Korsgaard
2013-05-03 18:41 ` [Buildroot] [PATCH v4 00/12] ARC port Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507095448.765b8cc4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.