Re: [Patch] MCE, APEI: Don't enable CMCI when Firmware First mode is set in HEST for corrected machine checks

[Borislav Petkov <bp@alien8.de>]

On Mon, May 06, 2013 at 08:32:46PM -0700, Max Asbock wrote:
> But this is glue code between MCE and APEI, therefore I thought a
> file named mce-apei.c would be a good place. If we put it into apei
> then we might have to export some of the MCE interfaces, whereas
> apei_hest_parse() is already exported.

Right, I don't want to expose any MCA internals to other subsystems
unless it is really necessary.

AFAICT, you need an ON and OFF switch for CMCI which is callable from
outside. So you can adapt/adjust the code in mce_intel.c to do so
without adding any other code.

Unless I'm missing something. But I don't think so, the high-level
sequence looks like this:

* MCA init
 -> CMCI init
* APEI init:
 -> if FF
    -> CMCI off

At a quick glance, simply doing:

	on_each_cpu(cmci_clear_func, NULL, 1);

should work. You'd need to define a proper cmci_clear_func prototype but
that should be trivial...

Pretty straight-forward, no?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--