From: Martin Jansa <martin.jansa@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 05/15] classes/lib: Update to use print as a function call
Date: Tue, 7 May 2013 17:40:57 +0200 [thread overview]
Message-ID: <20130507154057.GG3187@jama> (raw)
In-Reply-To: <1367931368-21504-5-git-send-email-richard.purdie@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On Tue, May 07, 2013 at 01:55:57PM +0100, Richard Purdie wrote:
> In python 3 print is a function call. In some cases bb.note is a more
> appropriate call to make.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/classes/sanity.bbclass | 7 ++++---
> meta/classes/sstate.bbclass | 6 +++---
> meta/lib/oe/path.py | 2 +-
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 766e97e..d4a8f5e 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -367,15 +367,16 @@ def check_sanity(sanity_data):
> try:
> from distutils.version import LooseVersion
> except ImportError:
> - def LooseVersion(v): print "WARNING: sanity.bbclass can't compare versions without python-distutils"; return 1
> - import commands
^ was removing "import commands" intentional? maybe it just belongs to
different patch in this series
> + def LooseVersion(v):
> + print("WARNING: sanity.bbclass can't compare versions without python-distutils")
> + return 1
>
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-05-07 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 12:55 [PATCH 01/15] classes/recipes/lib: Fix various python whitespace issues Richard Purdie
2013-05-07 12:55 ` [PATCH 02/15] core-image-minimal-initramfs: Remove odd quote characters Richard Purdie
2013-05-07 15:38 ` Martin Jansa
2013-05-07 12:55 ` [PATCH 03/15] clases/lib: Use modern exception syntax Richard Purdie
2013-05-07 12:55 ` [PATCH 04/15] classes: Use modern exception raising syntax Richard Purdie
2013-05-07 12:55 ` [PATCH 05/15] classes/lib: Update to use print as a function call Richard Purdie
2013-05-07 15:40 ` Martin Jansa [this message]
2013-05-07 12:55 ` [PATCH 06/15] buildstats: Update to ensure files are closed Richard Purdie
2013-05-07 12:55 ` [PATCH 07/15] bin/bitbake: Ensure early errors are shown to the user Richard Purdie
2013-05-13 1:31 ` Jonathan Liu
2013-05-07 12:56 ` [PATCH 08/15] meta/lib/oe: Replace StandardError with Exception Richard Purdie
2013-05-07 12:56 ` [PATCH 09/15] sanity.bbclass: Use open(), not file() Richard Purdie
2013-05-07 12:56 ` [PATCH 10/15] metadata_scm: Replace depracated operator Richard Purdie
2013-05-07 13:11 ` Phil Blundell
2013-05-07 12:56 ` [PATCH 11/15] insane: Open file in binary mode Richard Purdie
2013-05-07 12:56 ` [PATCH 12/15] image/kernel-module-split/eglibc-ld.inc: Remove has_key() usage Richard Purdie
2013-05-07 12:56 ` [PATCH 13/15] sanity/patch.py: Remove commands module usage Richard Purdie
2013-05-07 12:56 ` [PATCH 14/15] bitbake.conf: Use casting to ensure valid comparision Richard Purdie
2013-05-07 12:56 ` [PATCH 15/15] base.bbclass: Drop unused/obsolete import Richard Purdie
2013-05-07 15:37 ` [PATCH 01/15] classes/recipes/lib: Fix various python whitespace issues Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507154057.GG3187@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.