From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZoIi-0005To-Oi for qemu-devel@nongnu.org; Tue, 07 May 2013 16:15:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZoId-0003s3-W4 for qemu-devel@nongnu.org; Tue, 07 May 2013 16:15:52 -0400 Received: from mail-qe0-f41.google.com ([209.85.128.41]:33888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZoId-0003rq-S5 for qemu-devel@nongnu.org; Tue, 07 May 2013 16:15:47 -0400 Received: by mail-qe0-f41.google.com with SMTP id b10so609335qen.14 for ; Tue, 07 May 2013 13:15:47 -0700 (PDT) Sender: fluxion Date: Tue, 7 May 2013 15:10:18 -0500 From: mdroth Message-ID: <20130507201018.GA6474@vm> References: <518923DA.6030105@redhat.com> <1367945808-19979-1-git-send-email-lersek@redhat.com> <51893967.80503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51893967.80503@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, Laszlo Ersek , qemu-devel@nongnu.org On Tue, May 07, 2013 at 11:27:03AM -0600, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > > In Windows guests this may make a difference. > > > > Suggested-by: Eric Blake > > Signed-off-by: Laszlo Ersek > > --- > > qga/commands-posix.c | 22 ++++++++++++++++------ > > 1 files changed, 16 insertions(+), 6 deletions(-) > > > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > > index 04c6951..2eec712 100644 > > --- a/qga/commands-posix.c > > +++ b/qga/commands-posix.c > > Oh, and only NOW do I notice that this is in a file named > commands-posix.c that doesn't get compiled into the Windows build of qga > (there, we only build commands-win32.c, and THAT file always fails this > command, because no one has ported guest-file-open there yet). But I > guess there is still the argument that some weirdnix system exists that > isn't quite POSIX compliant and does have a distinct binary mode (maybe > someone plans on compiling qga for Cygwin instead of native windows, > since at least that would be able to open files when the > commands-win32.c variant doesn't?), so I still think the patch is worth > keeping. FWIW, I have some rough patches for w32 implementations of guest-file-* commands queued up that I'll be cleaning up for 1.6, so it's not so much theoretical as just a tad early :) > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >