Re: [PATCH] update to run lad at bootup

From: Denys Dmytriyenko <denys@ti.com>
To: Sajesh Kumar Saran <sajesh@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] update to run lad at bootup
Date: Tue, 7 May 2013 21:12:49 -0400	[thread overview]
Message-ID: <20130508011249.GO12982@edge> (raw)
In-Reply-To: <1367972890-14439-4-git-send-email-sajesh@ti.com>

Since this the first time you submit ti-ipc recipe, it is better to squash 
those 4 commits into one and submit a single patch...

On Tue, May 07, 2013 at 08:28:10PM -0400, Sajesh Kumar Saran wrote:
> ---
>  .../recipes-bsp/ti-ipc/ti-ipc_3.00.00.bb           |   16 ++++++++++---
>  .../recipes-bsp/ti-ipc/tiipclad-daemon.sh          |   24 ++++++++++++++++++++
>  2 files changed, 37 insertions(+), 3 deletions(-)
>  create mode 100755 meta-arago-extras/recipes-bsp/ti-ipc/tiipclad-daemon.sh
> 
> diff --git a/meta-arago-extras/recipes-bsp/ti-ipc/ti-ipc_3.00.00.bb b/meta-arago-extras/recipes-bsp/ti-ipc/ti-ipc_3.00.00.bb
> index d127020..92f54c0 100644
> --- a/meta-arago-extras/recipes-bsp/ti-ipc/ti-ipc_3.00.00.bb
> +++ b/meta-arago-extras/recipes-bsp/ti-ipc/ti-ipc_3.00.00.bb
> @@ -12,12 +12,12 @@ SECTION = "console"
>  COMPATIBLE_MACHINE = "keystone"
>  TARGET_PLATFORM = "tci6638"
>  
> -PR = "r19"
> +PR = "r21"
>  
>  BRANCH ?= "master"
>  SRCREV = "3.00.00.16_eng"
>  
> -SRC_URI = "git://git.ti.com/ipc/ipcdev.git;protocol=git;branch=${BRANCH}"
> +SRC_URI = "git://git.ti.com/ipc/ipcdev.git;protocol=git;branch=${BRANCH} file://tiipclad-daemon.sh"
>  
>  S = "${WORKDIR}/git"
>  
> @@ -33,4 +33,14 @@ FILES_${PN}-test = "${bindir}/NameServerApp_${TARGET_PLATFORM} \
>  					${bindir}/MessageQBench_${TARGET_PLATFORM} \
>  					${bindir}/ping_rpmsg"
>  
> -inherit autotools
> \ No newline at end of file

Can you try to avoid the above warning?

> +inherit autotools
> +
> +INITSCRIPT_NAME = "tiipclad-daemon.sh"
> +INITSCRIPT_PARAMS = "defaults 10"
> +
> +inherit update-rc.d
> +
> +do_install_append() {
> +	install -d ${D}${sysconfdir}/init.d/
> +	install -c -m 755 ${WORKDIR}/tiipclad-daemon.sh ${D}${sysconfdir}/init.d/${INITSCRIPT_NAME}
> +}
> \ No newline at end of file

Same here.

> diff --git a/meta-arago-extras/recipes-bsp/ti-ipc/tiipclad-daemon.sh b/meta-arago-extras/recipes-bsp/ti-ipc/tiipclad-daemon.sh
> new file mode 100755
> index 0000000..54b3888
> --- /dev/null
> +++ b/meta-arago-extras/recipes-bsp/ti-ipc/tiipclad-daemon.sh
> @@ -0,0 +1,24 @@
> +#! /bin/sh
> +
> +tiipclad_daemon=/usr/bin/lad_tci6638
> +tiipclad_params=lad.txt
> +
> +test -x "$tiipclad_daemon" || exit 0
> +
> +case "$1" in
> +  start)
> +    echo -n "Starting tiipclad daemon"
> +    start-stop-daemon --start --quiet --exec $tiipclad_daemon $tiipclad_params
> +    echo "."
> +    ;;
> +  stop)
> +    echo -n "Stopping tiipclad daemon"
> +    start-stop-daemon --stop --quiet --pidfile /var/run/tiipclad.pid
> +    echo "."
> +    ;;
> +  *)
> +    echo "Usage: /etc/init.d/tiipclad-daemon.sh {start|stop}"
> +    exit 1
> +esac
> +
> +exit 0
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago