All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Alex Deymo <deymo@chromium.org>
Cc: Vinicius Gomes <vinicius.gomes@openbossa.org>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	keybuk <keybuk@chromium.org>
Subject: Re: Short names on Extended Inquiry Result
Date: Wed, 8 May 2013 10:26:12 +0300	[thread overview]
Message-ID: <20130508072612.GD9401@x220> (raw)
In-Reply-To: <CAGd9gwiyUaedR6EOMOhpw64iA=_jkM+v08QsNJUteg_d+2mvmg@mail.gmail.com>

Hi Alex,

On Mon, May 06, 2013, Alex Deymo wrote:
> I though about several options and finally choose tho consider the
> short name as an unknown name and thus calling the confirm_name() with
> known_name in FALSE, but also report the device with the short name,
> while we ask for the long name.
> 
> This has the advantage of sending the device found signal earlier, but
> may have a problem in the following scenario:
> 1. We have a first call to update_found_devices() with a short name
> and report it to the user.
> 2. We request the full name.
> 3. The device doesn't reply to this request (for any reason)
> 4. We get a second call to update_found_devices() with a short name...
> but since we already know "a name" we don't request the long name.
> 
> To avoid this I think the best should be to include the name_complete
> field in the struct btd_device together with the name. What do you
> think?

I'm not completely sure about this. In theory you could have a (broken
or malicious) device with page scan disabled but inquiry scan enabled
and such a device would be causing us to block all other baseband
activity while we wait for a page timeout to happen each time we request
its name. Since we anyway re-request the name when connecting this might
not be worth it.

Johan

      reply	other threads:[~2013-05-08  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGd9gwjaECWWRE+Ux4XenbUO9L-QSsjnP6wLHEvH5q3sasWWkg@mail.gmail.com>
2013-05-04  1:14 ` Fwd: Short names on Extended Inquiry Result Alex Deymo
2013-05-04  1:55   ` Vinicius Gomes
2013-05-07  3:30     ` Alex Deymo
2013-05-08  7:26       ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130508072612.GD9401@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=deymo@chromium.org \
    --cc=keybuk@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.