From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 5/6] ASoC: ux500: Swap even/odd AD slot definitions Date: Wed, 8 May 2013 09:19:37 +0100 Message-ID: <20130508081937.GJ3102@gmail.com> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-6-git-send-email-fabio.baltieri@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by alsa0.perex.cz (Postfix) with ESMTP id 4077026168C for ; Wed, 8 May 2013 10:19:42 +0200 (CEST) Received: by mail-ea0-f180.google.com with SMTP id g14so752083eak.39 for ; Wed, 08 May 2013 01:19:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367997261-32048-6-git-send-email-fabio.baltieri@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Fabio Baltieri Cc: Ola Lilja , alsa-devel@alsa-project.org, Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown List-Id: alsa-devel@alsa-project.org T24gV2VkLCAwOCBNYXkgMjAxMywgRmFiaW8gQmFsdGllcmkgd3JvdGU6Cgo+IEFEIHNsb3RzIGRl ZmluaXRpb25zIGZvciBhYjg1MDAgY29kZWMgd2VyZSBlcnJvbmVvdXNseSBzd2FwcGVkIGJldHdl ZW4KPiBldmVuIGFuZCBvZGQgY2hhbm5lbHMuICBGaXggdGhpcyBieSBzd2FwcGluZyB0aGUgZGVm aW5pdGlvbnMgdG8gYmUKPiBjb2hlcmVudCB3aXRoIHRoZSBjaGFubmVsIG51bWJlci4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBGYWJpbyBCYWx0aWVyaSA8ZmFiaW8uYmFsdGllcmlAbGluYXJvLm9yZz4K PiAtLS0KPiAgc291bmQvc29jL2NvZGVjcy9hYjg1MDAtY29kZWMuaCB8IDM2ICsrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9u cygrKSwgMTggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9jb2RlY3Mv YWI4NTAwLWNvZGVjLmggYi9zb3VuZC9zb2MvY29kZWNzL2FiODUwMC1jb2RlYy5oCj4gaW5kZXgg MTE0ZjY5YS4uMzA2ZDBiYyAxMDA2NDQKPiAtLS0gYS9zb3VuZC9zb2MvY29kZWNzL2FiODUwMC1j b2RlYy5oCj4gKysrIGIvc291bmQvc29jL2NvZGVjcy9hYjg1MDAtY29kZWMuaAo+IEBAIC0zNDgs MjUgKzM0OCwyNSBAQAo+ICAKPiAgLyogQUI4NTAwX0FEU0xPVFNFTFggKi8KPiAgI2RlZmluZSBB Qjg1MDBfQURTTE9UU0VMWF9BRF9PVVQxX1RPX1NMT1RfT0RECTB4MDAKPiAtI2RlZmluZSBBQjg1 MDBfQURTTE9UU0VMWF9BRF9PVVQyX1RPX1NMT1RfT0RECTB4MDEKPiAtI2RlZmluZSBBQjg1MDBf QURTTE9UU0VMWF9BRF9PVVQzX1RPX1NMT1RfT0RECTB4MDIKPiAtI2RlZmluZSBBQjg1MDBfQURT TE9UU0VMWF9BRF9PVVQ0X1RPX1NMT1RfT0RECTB4MDMKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9U U0VMWF9BRF9PVVQ1X1RPX1NMT1RfT0RECTB4MDQKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9UU0VM WF9BRF9PVVQ2X1RPX1NMT1RfT0RECTB4MDUKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9B RF9PVVQ3X1RPX1NMT1RfT0RECTB4MDYKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9P VVQ4X1RPX1NMT1RfT0RECTB4MDcKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9aRVJPRVNf VE9fU0xPVF9PREQJMHgwOAo+IC0jZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX1RSSVNUQVRFX1RP X1NMT1RfT0RECTB4MEYKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQyX1RPX1NM T1RfT0RECTB4MTAKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQzX1RPX1NMT1Rf T0RECTB4MjAKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ0X1RPX1NMT1RfT0RE CTB4MzAKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ1X1RPX1NMT1RfT0RECTB4 NDAKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ2X1RPX1NMT1RfT0RECTB4NTAK PiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ3X1RPX1NMT1RfT0RECTB4NjAKPiAr I2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ4X1RPX1NMT1RfT0RECTB4NzAKPiArI2Rl ZmluZSBBQjg1MDBfQURTTE9UU0VMWF9aRVJPRVNfVE9fU0xPVF9PREQJMHg4MAo+ICsjZGVmaW5l IEFCODUwMF9BRFNMT1RTRUxYX1RSSVNUQVRFX1RPX1NMT1RfT0RECTB4RjAKPiAgI2RlZmluZSBB Qjg1MDBfQURTTE9UU0VMWF9BRF9PVVQxX1RPX1NMT1RfRVZFTgkweDAwCj4gLSNkZWZpbmUgQUI4 NTAwX0FEU0xPVFNFTFhfQURfT1VUMl9UT19TTE9UX0VWRU4JMHgxMAo+IC0jZGVmaW5lIEFCODUw MF9BRFNMT1RTRUxYX0FEX09VVDNfVE9fU0xPVF9FVkVOCTB4MjAKPiAtI2RlZmluZSBBQjg1MDBf QURTTE9UU0VMWF9BRF9PVVQ0X1RPX1NMT1RfRVZFTgkweDMwCj4gLSNkZWZpbmUgQUI4NTAwX0FE U0xPVFNFTFhfQURfT1VUNV9UT19TTE9UX0VWRU4JMHg0MAo+IC0jZGVmaW5lIEFCODUwMF9BRFNM T1RTRUxYX0FEX09VVDZfVE9fU0xPVF9FVkVOCTB4NTAKPiAtI2RlZmluZSBBQjg1MDBfQURTTE9U U0VMWF9BRF9PVVQ3X1RPX1NMT1RfRVZFTgkweDYwCj4gLSNkZWZpbmUgQUI4NTAwX0FEU0xPVFNF TFhfQURfT1VUOF9UT19TTE9UX0VWRU4JMHg3MAo+IC0jZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxY X1pFUk9FU19UT19TTE9UX0VWRU4JMHg4MAo+IC0jZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX1RS SVNUQVRFX1RPX1NMT1RfRVZFTgkweEYwCj4gKyNkZWZpbmUgQUI4NTAwX0FEU0xPVFNFTFhfQURf T1VUMl9UT19TTE9UX0VWRU4JMHgwMQo+ICsjZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX0FEX09V VDNfVE9fU0xPVF9FVkVOCTB4MDIKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ0 X1RPX1NMT1RfRVZFTgkweDAzCj4gKyNkZWZpbmUgQUI4NTAwX0FEU0xPVFNFTFhfQURfT1VUNV9U T19TTE9UX0VWRU4JMHgwNAo+ICsjZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX0FEX09VVDZfVE9f U0xPVF9FVkVOCTB4MDUKPiArI2RlZmluZSBBQjg1MDBfQURTTE9UU0VMWF9BRF9PVVQ3X1RPX1NM T1RfRVZFTgkweDA2Cj4gKyNkZWZpbmUgQUI4NTAwX0FEU0xPVFNFTFhfQURfT1VUOF9UT19TTE9U X0VWRU4JMHgwNwo+ICsjZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX1pFUk9FU19UT19TTE9UX0VW RU4JMHgwOAo+ICsjZGVmaW5lIEFCODUwMF9BRFNMT1RTRUxYX1RSSVNUQVRFX1RPX1NMT1RfRVZF TgkweDBGCj4gICNkZWZpbmUgQUI4NTAwX0FEU0xPVFNFTFhfRVZFTl9TSElGVAkJMAo+ICAjZGVm aW5lIEFCODUwMF9BRFNMT1RTRUxYX09ERF9TSElGVAkJNAoKQWNrZWQtYnk6IExlZSBKb25lcyA8 bGVlLmpvbmVzQGxpbmFyby5vcmc+CgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBM YW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxp bmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353Ab3EHITq (ORCPT ); Wed, 8 May 2013 04:19:46 -0400 Received: from mail-ea0-f176.google.com ([209.85.215.176]:39865 "EHLO mail-ea0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235Ab3EHITn (ORCPT ); Wed, 8 May 2013 04:19:43 -0400 Date: Wed, 8 May 2013 09:19:37 +0100 From: Lee Jones To: Fabio Baltieri Cc: Mark Brown , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Ola Lilja Subject: Re: [PATCH 5/6] ASoC: ux500: Swap even/odd AD slot definitions Message-ID: <20130508081937.GJ3102@gmail.com> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-6-git-send-email-fabio.baltieri@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367997261-32048-6-git-send-email-fabio.baltieri@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 May 2013, Fabio Baltieri wrote: > AD slots definitions for ab8500 codec were erroneously swapped between > even and odd channels. Fix this by swapping the definitions to be > coherent with the channel number. > > Signed-off-by: Fabio Baltieri > --- > sound/soc/codecs/ab8500-codec.h | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff --git a/sound/soc/codecs/ab8500-codec.h b/sound/soc/codecs/ab8500-codec.h > index 114f69a..306d0bc 100644 > --- a/sound/soc/codecs/ab8500-codec.h > +++ b/sound/soc/codecs/ab8500-codec.h > @@ -348,25 +348,25 @@ > > /* AB8500_ADSLOTSELX */ > #define AB8500_ADSLOTSELX_AD_OUT1_TO_SLOT_ODD 0x00 > -#define AB8500_ADSLOTSELX_AD_OUT2_TO_SLOT_ODD 0x01 > -#define AB8500_ADSLOTSELX_AD_OUT3_TO_SLOT_ODD 0x02 > -#define AB8500_ADSLOTSELX_AD_OUT4_TO_SLOT_ODD 0x03 > -#define AB8500_ADSLOTSELX_AD_OUT5_TO_SLOT_ODD 0x04 > -#define AB8500_ADSLOTSELX_AD_OUT6_TO_SLOT_ODD 0x05 > -#define AB8500_ADSLOTSELX_AD_OUT7_TO_SLOT_ODD 0x06 > -#define AB8500_ADSLOTSELX_AD_OUT8_TO_SLOT_ODD 0x07 > -#define AB8500_ADSLOTSELX_ZEROES_TO_SLOT_ODD 0x08 > -#define AB8500_ADSLOTSELX_TRISTATE_TO_SLOT_ODD 0x0F > +#define AB8500_ADSLOTSELX_AD_OUT2_TO_SLOT_ODD 0x10 > +#define AB8500_ADSLOTSELX_AD_OUT3_TO_SLOT_ODD 0x20 > +#define AB8500_ADSLOTSELX_AD_OUT4_TO_SLOT_ODD 0x30 > +#define AB8500_ADSLOTSELX_AD_OUT5_TO_SLOT_ODD 0x40 > +#define AB8500_ADSLOTSELX_AD_OUT6_TO_SLOT_ODD 0x50 > +#define AB8500_ADSLOTSELX_AD_OUT7_TO_SLOT_ODD 0x60 > +#define AB8500_ADSLOTSELX_AD_OUT8_TO_SLOT_ODD 0x70 > +#define AB8500_ADSLOTSELX_ZEROES_TO_SLOT_ODD 0x80 > +#define AB8500_ADSLOTSELX_TRISTATE_TO_SLOT_ODD 0xF0 > #define AB8500_ADSLOTSELX_AD_OUT1_TO_SLOT_EVEN 0x00 > -#define AB8500_ADSLOTSELX_AD_OUT2_TO_SLOT_EVEN 0x10 > -#define AB8500_ADSLOTSELX_AD_OUT3_TO_SLOT_EVEN 0x20 > -#define AB8500_ADSLOTSELX_AD_OUT4_TO_SLOT_EVEN 0x30 > -#define AB8500_ADSLOTSELX_AD_OUT5_TO_SLOT_EVEN 0x40 > -#define AB8500_ADSLOTSELX_AD_OUT6_TO_SLOT_EVEN 0x50 > -#define AB8500_ADSLOTSELX_AD_OUT7_TO_SLOT_EVEN 0x60 > -#define AB8500_ADSLOTSELX_AD_OUT8_TO_SLOT_EVEN 0x70 > -#define AB8500_ADSLOTSELX_ZEROES_TO_SLOT_EVEN 0x80 > -#define AB8500_ADSLOTSELX_TRISTATE_TO_SLOT_EVEN 0xF0 > +#define AB8500_ADSLOTSELX_AD_OUT2_TO_SLOT_EVEN 0x01 > +#define AB8500_ADSLOTSELX_AD_OUT3_TO_SLOT_EVEN 0x02 > +#define AB8500_ADSLOTSELX_AD_OUT4_TO_SLOT_EVEN 0x03 > +#define AB8500_ADSLOTSELX_AD_OUT5_TO_SLOT_EVEN 0x04 > +#define AB8500_ADSLOTSELX_AD_OUT6_TO_SLOT_EVEN 0x05 > +#define AB8500_ADSLOTSELX_AD_OUT7_TO_SLOT_EVEN 0x06 > +#define AB8500_ADSLOTSELX_AD_OUT8_TO_SLOT_EVEN 0x07 > +#define AB8500_ADSLOTSELX_ZEROES_TO_SLOT_EVEN 0x08 > +#define AB8500_ADSLOTSELX_TRISTATE_TO_SLOT_EVEN 0x0F > #define AB8500_ADSLOTSELX_EVEN_SHIFT 0 > #define AB8500_ADSLOTSELX_ODD_SHIFT 4 Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog