From: Stephen Hemminger <stephen@networkplumber.org>
To: PJ Waskiewicz <peter.p.waskiewicz.jr@linux.intel.com>
Cc: Pravin B Shelar <pshelar@nicira.com>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Cong Wang <amwang@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol()
Date: Wed, 8 May 2013 09:23:13 -0700 [thread overview]
Message-ID: <20130508092313.677f9717@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <518A01F9.8090403@linux.intel.com>
On Wed, 08 May 2013 00:42:49 -0700
PJ Waskiewicz <peter.p.waskiewicz.jr@linux.intel.com> wrote:
> On 5/7/2013 11:41 PM, Pravin B Shelar wrote:
> > Rather than having logic to calculate inner protocol in every
> > tunnel gso handler move it to gso code. This simplifies code.
>
> Moving code that isn't used on a regular basis to hotpath for most
> networking to simplify code isn't always a good thing.
>
> Have you run tests on non-tunneled streams using GSO to make sure there
> isn't an adverse impact to performance due to the new, untaken branch?
>
> -PJ
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Maybe use unlikely here?
It looks like more and more of this tunnel unwrapping needs to be handled here
(vxlan? ipip?) probably want more general switch statement and per-protocol functions.
next prev parent reply other threads:[~2013-05-08 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 6:41 [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol() Pravin B Shelar
2013-05-08 7:42 ` PJ Waskiewicz
2013-05-08 16:23 ` Stephen Hemminger [this message]
2013-05-08 20:15 ` David Miller
2013-05-09 2:32 ` Pravin Shelar
2013-05-09 2:43 ` David Miller
2013-05-09 2:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508092313.677f9717@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@linux.intel.com \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.