From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration Date: Wed, 8 May 2013 12:11:10 +0100 Message-ID: <20130508111110.GD3459@gmail.com> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-5-git-send-email-fabio.baltieri@linaro.org> <20130508110149.GF7478@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com [209.85.215.176]) by alsa0.perex.cz (Postfix) with ESMTP id 62EDD2652B3 for ; Wed, 8 May 2013 13:11:14 +0200 (CEST) Received: by mail-ea0-f176.google.com with SMTP id h14so836870eak.7 for ; Wed, 08 May 2013 04:11:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130508110149.GF7478@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Ola Lilja , alsa-devel@alsa-project.org, Fabio Baltieri , Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gV2VkLCAwOCBNYXkgMjAxMywgTWFyayBCcm93biB3cm90ZToKCj4gT24gV2VkLCBNYXkgMDgs IDIwMTMgYXQgMDk6MTQ6MTlBTSArMDIwMCwgRmFiaW8gQmFsdGllcmkgd3JvdGU6Cj4gPiBVcGRh dGUgYWI4NTAwLWNvZGVjIGFuZCBtb3A1MDBfYWI4NTAwIHR4IHNsb3QgY29uZmlndXJhdGlvbiB0 byByZWZsZWN0Cj4gPiB0aGUgYWN0dWFsIG9uZSB1c2VkIGJ5IFNURS4gIEFsc28gdXBkYXRlIGEg d3JvbmcgY29tbWVudCBpbiB0aGUgcHJvY2Vzcy4KPiAKPiBUaGlzIHNlZW1zIHdyb25nLCB0aGUg aW5kaXZpZHVhbCBjaGlwIGRyaXZlcnMgc2hvdWxkIGp1c3QgYmUgZG9pbmcKPiB3aGF0ZXZlciB0 aGV5J3JlIGJlaW5nIHRvbGQgYnkgdGhlIG1hY2hpbmUgZHJpdmVyLiAgU291bmRzIGxpa2UgdGhl cmUncwo+IHR3byBmaXhlcyBuZWVkZWQgaGVyZSAtIG9uZSBpcyB0byBjaGFuZ2UgdGhlIFRETSBB UEkgc28gdGhhdCB0aGUgY2hpcAo+IGRyaXZlcnMgYXJlIGp1c3QgaW1wbGVtZW50aW5nIGNvbmZp Z3VyYXRpb24gc3VwcGxpZWQgYnkgdGhlIG1hY2hpbmUKPiBkcml2ZXIgYW5kIHRoZSBvdGhlciBp cyB0byBjaGFuZ2UgdGhlIGNvbmZpZ3VyYXRpb24gYmVpbmcgZG9uZSB0bwo+IHdoYXRldmVyIGlz IGRlc2lyZWQuCgpEbyB5b3UgbWVhbiB0aGF0IHRoZSBvcmlnaW5hbCBpbXBsZW1lbnRhdGlvbiBp cyBpbmNvcnJlY3QsIG9yIHRoYXQKdGhpcyBwYXRjaCBpcyBkb2luZyB0aGUgd3JvbmcgdGhpbmc/ IEkgdGhpbmsgdGhpcyBwYXRjaCBpcyBhIGJ1Z2ZpeApyYXRoZXIgdGhhbiBhIG9wcG9ydHVuaXR5 IHRvIHJlZmFjdG9yIHRoZSBkcml2ZXIuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3Nv biBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1h aWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxz YS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740Ab3EHLLQ (ORCPT ); Wed, 8 May 2013 07:11:16 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:53157 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863Ab3EHLLP (ORCPT ); Wed, 8 May 2013 07:11:15 -0400 Date: Wed, 8 May 2013 12:11:10 +0100 From: Lee Jones To: Mark Brown Cc: Fabio Baltieri , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Ola Lilja Subject: Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration Message-ID: <20130508111110.GD3459@gmail.com> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-5-git-send-email-fabio.baltieri@linaro.org> <20130508110149.GF7478@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130508110149.GF7478@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 May 2013, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote: > > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect > > the actual one used by STE. Also update a wrong comment in the process. > > This seems wrong, the individual chip drivers should just be doing > whatever they're being told by the machine driver. Sounds like there's > two fixes needed here - one is to change the TDM API so that the chip > drivers are just implementing configuration supplied by the machine > driver and the other is to change the configuration being done to > whatever is desired. Do you mean that the original implementation is incorrect, or that this patch is doing the wrong thing? I think this patch is a bugfix rather than a opportunity to refactor the driver. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog