Re: [PATCH 1/2] initscript-debugfs recipe: needed by ti-multiprocmgr, system printf messages coming from debugfs

[Denys Dmytriyenko <denys@ti.com>]

On Wed, May 08, 2013 at 01:04:09PM +0000, Maupin, Chase wrote:
> > Subject: [meta-arago] [PATCH 1/2] initscript-debugfs recipe:
> > needed by ti-multiprocmgr, system printf messages coming from
> > debugfs
> > 
> > From: Jingting Zhou <a0221004@ares-ubuntu>
> 
> So close you are almost there.  A couple of points.

Ah, words of encouragement - good idea :) Few more comments:


> 1. You need to fix your e-mail.  You should use your ti.com address.  This 
> is the e-mail setting in your u-boot config.

1. To quickly set your email in git configuration, use this line:

git config --global user.email zhoujt@ti.com

To check current config, git config -l
But getting more familiar with git in general is a good idea - use a 
presentation or training material.


> 2. The commit message should be something like:
> 
> Recipe: brief description of change
> 
> * Detail 1 about change and why
> * Detail 2 about change and why
> 
> Signed-off-by: your name <your email>

2. What Chase explained for the commit message is good and will start you up, 
but it's just a very brief version of the Commit Message Guidelines here:
http://openembedded.org/wiki/Commit_Patch_Message_Guidelines


> If you have your e-mail configured then you can have your signed-off-by 
> automatically added to your commit message by using -s when commiting.  I'll 
> send you a git presentation that has some info on setting these.

-- 
Denys



> > ---
> >  .../initscript-debugfs/files/debugfs.sh            |   40
> > ++++++++++++++++++++
> >  .../initscript-debugfs/initscript-debugfs.bb       |   20
> > ++++++++++
> >  2 files changed, 60 insertions(+)
> >  create mode 100755 meta-arago-extras/recipes-bsp/initscript-
> > debugfs/files/debugfs.sh
> >  create mode 100755 meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb
> > 
> > diff --git a/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/files/debugfs.sh b/meta-arago-extras/recipes-
> > bsp/initscript-debugfs/files/debugfs.sh
> > new file mode 100755
> > index 0000000..9b26279
> > --- /dev/null
> > +++ b/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/files/debugfs.sh
> > @@ -0,0 +1,40 @@
> > +#!/bin/sh
> > +
> > +#   Copyright 2012, Texas Instruments, Inc.
> > +#
> > +#   Redistribution and use in source and binary forms, with or
> > without
> > +#   modification, are permitted provided that the following
> > conditions
> > +#   are met:
> > +#
> > +#     Redistributions of source code must retain the above
> > copyright
> > +#     notice, this list of conditions and the following
> > disclaimer.
> > +#
> > +#     Redistributions in binary form must reproduce the above
> > copyright
> > +#     notice, this list of conditions and the following
> > disclaimer in the
> > +#     documentation and/or other materials provided with the
> > +#     distribution.
> > +#
> > +#     Neither the name of Texas Instruments Incorporated nor the
> > names of
> > +#     its contributors may be used to endorse or promote
> > products derived
> > +#     from this software without specific prior written
> > permission.
> > +#
> > +#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> > CONTRIBUTORS
> > +#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
> > BUT NOT
> > +#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> > FITNESS FOR
> > +#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> > COPYRIGHT
> > +#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> > INCIDENTAL,
> > +#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> > NOT
> > +#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> > LOSS OF USE,
> > +#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> > AND ON ANY
> > +#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> > OR TORT
> > +#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> > OF THE USE
> > +#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > DAMAGE.
> > +#
> > +
> > +
> > +if ! [ -e /debug ] ; then
> > +  mkdir -p /debug
> > +fi
> > +mount -t debugfs debugfs /debug
> > +
> > +exit 0
> > diff --git a/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb b/meta-arago-extras/recipes-
> > bsp/initscript-debugfs/initscript-debugfs.bb
> > new file mode 100755
> > index 0000000..f8145ba
> > --- /dev/null
> > +++ b/meta-arago-extras/recipes-bsp/initscript-
> > debugfs/initscript-debugfs.bb
> > @@ -0,0 +1,20 @@
> > +DESCRIPTION = "Initscripts for debugfs"
> > +LICENSE = "BSD"
> > +
> > +LIC_FILES_CHKSUM =
> > "file://debugfs.sh;startline=3;endline=32;md5=4d96701a693bf321ad2
> > d15026a285446"
> > +
> > +PR ="r0"
> > +
> > +SRC_URI = "file://debugfs.sh"
> > +
> > +INITSCRIPT_NAME = "debugfs.sh"
> > +INITSCRIPT_PARAMS = "start 09 S ."
> > +
> > +inherit update-rc.d
> > +
> > +S = "${WORKDIR}"
> > +
> > +do_install () {
> > +	install -d ${D}${sysconfdir}/init.d/
> > +	install -c -m 755 ${WORKDIR}/debugfs.sh
> > ${D}${sysconfdir}/init.d/debugfs.sh
> > +}
> > --
> > 1.7.9.5
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago