From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 2/8] ARM:global_timer: Add ARM global timer support. Date: Wed, 8 May 2013 18:23:59 +0200 Message-ID: <201305081823.59938.arnd@arndb.de> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <20130508144907.GB20820@mudshark.cambridge.arm.com> <518A73CF.8000309@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <518A73CF.8000309-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Stuart MENEFY Cc: Srinivas KANDAGATLA , Viresh Kumar , Will Deacon , Jiri Slaby , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , Samuel Ortiz , Nicolas Pitre , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jason Cooper , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Stephen Warren , Dong Aisheng , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Greg Kroah-Hartman , Mark Brown , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-serial@vger.kernel.org On Wednesday 08 May 2013, Stuart MENEFY wrote: > Fortunately the earliest version of these SoCs uses r2p2, so we avoided that > particular issue. But as the code doesn't attempt to work around these > problems a check on the version number might be a good idea to prevent other > people accidentally hitting it. > Yes, good idea. I would put the version number in the compatible property and document both the working and non-working versions in the binding, but put a comment explaining the situation into the driver. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 8 May 2013 18:23:59 +0200 Subject: [RFC 2/8] ARM:global_timer: Add ARM global timer support. In-Reply-To: <518A73CF.8000309@st.com> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <20130508144907.GB20820@mudshark.cambridge.arm.com> <518A73CF.8000309@st.com> Message-ID: <201305081823.59938.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 08 May 2013, Stuart MENEFY wrote: > Fortunately the earliest version of these SoCs uses r2p2, so we avoided that > particular issue. But as the code doesn't attempt to work around these > problems a check on the version number might be a good idea to prevent other > people accidentally hitting it. > Yes, good idea. I would put the version number in the compatible property and document both the working and non-working versions in the binding, but put a comment explaining the situation into the driver. Arnd