From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board Date: Thu, 9 May 2013 08:56:45 -0700 Message-ID: <20130509155645.GB31554@atomide.com> References: <20130508194504.GD32546@atomide.com> <20130509003606.GE31290@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:49090 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754050Ab3EIP4u (ORCPT ); Thu, 9 May 2013 11:56:50 -0400 Content-Disposition: inline In-Reply-To: <20130509003606.GE31290@titan.lakedaemon.net> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jason Cooper Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org * Jason Cooper [130508 17:41]: > On Wed, May 08, 2013 at 12:45:04PM -0700, Tony Lindgren wrote: > > * Jason Cooper [130508 12:29]: > > > > > > Tony has been helping me out offline with this, and he suggested trying the > > > gpmc against Linus' ToT. Which locks up before it even has a chance to get > > > going. So this series is against v3.9. > > > > You may have better luck with today's mainline treeand the following fix: > > > > http://lkml.org/lkml/2013/5/8/374# > > Ok, I'm attempting to do that, but got this for 'make dtbs': > > ERROR (phandle_references): Reference to non-existent node or label "usb2_phy" > > ERROR: Input tree has errors, aborting (use -f to force output) > make[1]: *** [arch/arm/boot/dts/omap3-wireless_plus.dtb] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [dtbs] Error 2 > > which was created by: > > ad871c10 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards > > It assumes the board has twl4030 (and then includes it). Bootlogs from > the vendor provided kernel don't show a single message from twl4030, so > I've omitted it. > > Assuming I did the correct thing by omitting the twl4030, I think the > correct answer is to declare the phy in the dts files, like so: Thanks, that is correct. We should not assume any PMIC with a processor as it can also be a custom chip. For example, Nokia n8x0 is using their retu + tahvo chips instead of tps chips. I'll apply your patch into omap-for-v3.10/fixes. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 9 May 2013 08:56:45 -0700 Subject: [RFC PATCH 0/3] ARM: omap3: add Seagate Wireless Plus board In-Reply-To: <20130509003606.GE31290@titan.lakedaemon.net> References: <20130508194504.GD32546@atomide.com> <20130509003606.GE31290@titan.lakedaemon.net> Message-ID: <20130509155645.GB31554@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Jason Cooper [130508 17:41]: > On Wed, May 08, 2013 at 12:45:04PM -0700, Tony Lindgren wrote: > > * Jason Cooper [130508 12:29]: > > > > > > Tony has been helping me out offline with this, and he suggested trying the > > > gpmc against Linus' ToT. Which locks up before it even has a chance to get > > > going. So this series is against v3.9. > > > > You may have better luck with today's mainline treeand the following fix: > > > > http://lkml.org/lkml/2013/5/8/374# > > Ok, I'm attempting to do that, but got this for 'make dtbs': > > ERROR (phandle_references): Reference to non-existent node or label "usb2_phy" > > ERROR: Input tree has errors, aborting (use -f to force output) > make[1]: *** [arch/arm/boot/dts/omap3-wireless_plus.dtb] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [dtbs] Error 2 > > which was created by: > > ad871c10 ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards > > It assumes the board has twl4030 (and then includes it). Bootlogs from > the vendor provided kernel don't show a single message from twl4030, so > I've omitted it. > > Assuming I did the correct thing by omitting the twl4030, I think the > correct answer is to declare the phy in the dts files, like so: Thanks, that is correct. We should not assume any PMIC with a processor as it can also be a custom chip. For example, Nokia n8x0 is using their retu + tahvo chips instead of tps chips. I'll apply your patch into omap-for-v3.10/fixes. Regards, Tony