From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] more vfs.git stuff
Date: Thu, 9 May 2013 21:34:29 +0100 [thread overview]
Message-ID: <20130509203428.GI25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130509202815.GH25399@ZenIV.linux.org.uk>
On Thu, May 09, 2013 at 09:28:15PM +0100, Al Viro wrote:
> The only place checking that sucker is in a fairly large area protected by
> ->b_lock (in mon_bin_event()); I really don't want to dig deep enough to
> tell if having it changed right after it had been checked is safe. OTOH,
> from a cursory look through that code it appears that the whole map_count
> thing is completely misguided - it seems to assume that ->open() is called for
> each VMA, including the one created by mmap(2). Sigh...
Less cursory one shows that they do call their ->open() from their ->mmap().
OTOH, the code looking and ->mmap_active looks fishy - what happens if we
do allocation before mmap() happens?
Anyway, let's just drop that commit for now; it clearly needs more RTFS.
Could you pull for-linus^?
next prev parent reply other threads:[~2013-05-09 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 19:26 [git pull] more vfs.git stuff Al Viro
2013-05-09 20:12 ` Linus Torvalds
2013-05-09 20:21 ` Linus Torvalds
2013-05-09 20:28 ` Al Viro
2013-05-09 20:34 ` Al Viro [this message]
2013-05-09 20:46 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2016-01-21 23:04 Al Viro
2016-01-22 18:26 ` Linus Torvalds
2016-01-22 18:42 ` Al Viro
2016-01-22 18:45 ` Linus Torvalds
2013-07-14 17:34 Al Viro
2013-05-07 19:17 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509203428.GI25399@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.