From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH v2 1/2] clk: Disable unused clocks after deferred probing is done Date: Fri, 10 May 2013 08:45:20 +0200 Message-ID: <20130510064520.GI3041@game.jcrosoft.org> References: <1368076726-11492-1-git-send-email-skannan@codeaurora.org> <1368124502-18830-1-git-send-email-skannan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 6.mo2.mail-out.ovh.net ([87.98.165.38]:37736 "EHLO mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751241Ab3EJGt4 (ORCPT ); Fri, 10 May 2013 02:49:56 -0400 Received: from mail21.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo2.mail-out.ovh.net (Postfix) with SMTP id E7151DC1505 for ; Fri, 10 May 2013 08:49:50 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1368124502-18830-1-git-send-email-skannan@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Saravana Kannan Cc: Greg Kroah-Hartman , Grant Likely , Mike Turquette , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org, Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 11:35 Thu 09 May , Saravana Kannan wrote: > With deferred probing, late_initcall() is too soon to declare a clock as > unused. Wait for deferred probing to finish before declaring a clock as > unused. Since deferred probing is done in late_initcall(), do the unused > check to late_initcall_sync. Nack for both regulator & clk you can not known when the clock need to be shutdown example display splash screen set by the bootloader and display as module Best Regards, J. > > Signed-off-by: Saravana Kannan > --- > drivers/clk/clk.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index fe4055f..5ecb64c 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -534,7 +534,7 @@ static int clk_disable_unused(void) > > return 0; > } > -late_initcall(clk_disable_unused); > +late_initcall_sync(clk_disable_unused); > > /*** helper functions ***/ > > -- > 1.7.8.3 > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Fri, 10 May 2013 08:45:20 +0200 Subject: [PATCH v2 1/2] clk: Disable unused clocks after deferred probing is done In-Reply-To: <1368124502-18830-1-git-send-email-skannan@codeaurora.org> References: <1368076726-11492-1-git-send-email-skannan@codeaurora.org> <1368124502-18830-1-git-send-email-skannan@codeaurora.org> Message-ID: <20130510064520.GI3041@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11:35 Thu 09 May , Saravana Kannan wrote: > With deferred probing, late_initcall() is too soon to declare a clock as > unused. Wait for deferred probing to finish before declaring a clock as > unused. Since deferred probing is done in late_initcall(), do the unused > check to late_initcall_sync. Nack for both regulator & clk you can not known when the clock need to be shutdown example display splash screen set by the bootloader and display as module Best Regards, J. > > Signed-off-by: Saravana Kannan > --- > drivers/clk/clk.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index fe4055f..5ecb64c 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -534,7 +534,7 @@ static int clk_disable_unused(void) > > return 0; > } > -late_initcall(clk_disable_unused); > +late_initcall_sync(clk_disable_unused); > > /*** helper functions ***/ > > -- > 1.7.8.3 > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel