From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] libxl: Make 'xl vcpu-set' work properly on
 overcommited hosts.
Date: Fri, 10 May 2013 12:35:21 -0700 (PDT)
Message-ID: <20130510193521.GB4019@phenom.dumpdata.com>
References: <1367959244-5413-1-git-send-email-konrad.wilk@oracle.com>
	<CAFLBxZazNdh0Mo-AyVVfC+iAPTCVJrcivKgojKJdfBRnYNypPw@mail.gmail.com>
	<1368009999.26321.223.camel@zakaz.uk.xensource.com>
	<20130508142903.GA9314@phenom.dumpdata.com>
	<20874.30569.891795.43120@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20874.30569.891795.43120@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, May 08, 2013 at 05:03:53PM +0100, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] libxl: Make 'xl vcpu-set' work properly on overcommited hosts."):
> > Note that all of the libxl_cpu_bitmap_[test|set] silently ignore
> > any test or sets above its size:
> > 
> >      if (bit >= bitmap->size * 8)
> >          return 0;
> > 
> > so we were never notified off this bug.
> 
> I hadn't spotted that.  Arguably "return 0" should be "abort()".

I am really hesistant about doing this in Xen 4.3. There are a bunch
of places where this is used and I fear this will cause tons of
asserts and more bugs to crep up which will make George MAD!!!


I can certainly prep a patch for Xen 4.4 and slowly fix the fallout.
> 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Is that for adding an assert or to the patch?
> 
> Thanks,
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>