All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Borislav Petkov <bp@alien8.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SyS symbol munging.
Date: Fri, 10 May 2013 22:17:16 +0100	[thread overview]
Message-ID: <20130510211716.GN25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130510205622.GD9583@home.goodmis.org>

On Fri, May 10, 2013 at 04:56:22PM -0400, Steven Rostedt wrote:
> On Fri, May 10, 2013 at 09:05:03PM +0100, Al Viro wrote:
> > On Fri, May 10, 2013 at 09:55:00PM +0200, Borislav Petkov wrote:
> > > On Fri, May 10, 2013 at 12:35:10PM -0700, Andrew Morton wrote:
> > > > I forget who did this initially and peeling back those layers with git
> > > > is tiresome.
> > > 
> > > 1a94bc34768e4 from 2009, although those SyS* things started appearing in
> > > stack traces only recently AFAIR.
> > 
> > Note that both sys_something and SyS_something end up in vmlinux symbol
> > table, refering to the same address.  AFAICS, what matters is which one
> > goes first.  May be even linker-dependent...
> 
> Actually, it's the first one that kallsyms finds in its binary search.
> 
> If the table is layed out a little differently, it may find the first
> one or the second one.

Then maybe it's worth trying to kill these aliases in kallsyms.  We also
have compat_SyS_something stuff.  Actually, most of the aliases seem to be
of those forms - after removing (a_sys_b,a_SyS_b) pairs the list of duplicates
in System.map shrinks by factor of 15 or so...

  reply	other threads:[~2013-05-10 21:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 19:24 SyS symbol munging Dave Jones
2013-05-10 19:35 ` Andrew Morton
2013-05-10 19:45   ` Randy Dunlap
2013-05-10 19:55   ` Borislav Petkov
2013-05-10 20:05     ` Al Viro
2013-05-10 20:17       ` Borislav Petkov
2013-05-10 20:56       ` Steven Rostedt
2013-05-10 21:17         ` Al Viro [this message]
2013-05-10 19:40 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130510211716.GN25399@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.