From: Jonathan Nieder <jrnieder@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: fix default regex settings on Darwin
Date: Sat, 11 May 2013 00:04:23 -0700 [thread overview]
Message-ID: <20130511070423.GG3394@elie> (raw)
In-Reply-To: <CAJDDKr5StD_bDr7+29qEYc4Lza+q8w=ZrHuwdSLwvCSru3YYWQ@mail.gmail.com>
David Aguilar wrote:
> expecting success:
> # if this test fails, re-build git with NO_REGEX=1
> test-regex
>
> fatal: regex bug confirmed: re-build git with NO_REGEX=1
Thanks. Gah. That means that regcomp() with REG_NEWLINE is letting
[^={} \t]+
match the newline in
={}\nfred
despite the POSIX requirement
A <newline> in string shall not be matched by a period outside
a bracket expression or by any form of a non-matching list
where
A non-matching list expression begins with a <circumflex> ('^')
and specifies a list that shall match any single-character
collating element except for the expressions represented in
the list after the leading <circumflex>.
and if I understand you correctly, this is a regression in Apple
libc. :(
With the commit message modified to mention the "fatal: regex bug
confirmed: re-build git with NO_REGEX=1" and uname -a output,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Do you know if this has been reported to Apple and
openradar.appspot.com?
next prev parent reply other threads:[~2013-05-11 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 5:08 [PATCH] Makefile: fix default regex settings on Darwin David Aguilar
2013-05-11 6:31 ` Jonathan Nieder
2013-05-11 6:44 ` David Aguilar
2013-05-11 7:04 ` Jonathan Nieder [this message]
2013-05-11 7:55 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130511070423.GG3394@elie \
--to=jrnieder@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.