From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ub1eU-0005dS-Fd for mharc-grub-devel@gnu.org; Sat, 11 May 2013 00:43:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub1eS-0005dK-Df for grub-devel@gnu.org; Sat, 11 May 2013 00:43:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ub1eQ-0001yQ-IM for grub-devel@gnu.org; Sat, 11 May 2013 00:43:20 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:44083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub1eQ-0001yL-9k for grub-devel@gnu.org; Sat, 11 May 2013 00:43:18 -0400 Received: by mail-lb0-f182.google.com with SMTP id r11so4866144lbv.13 for ; Fri, 10 May 2013 21:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type; bh=HM40moATNX7hW1y09RLn56drWC+W9accLVx9VRZ3EG4=; b=qusEi0elV86Qa2wP4GY6gn/3jeOlBwbhZ3eDLKF6m4pTlvjjbl3YNcc6mTpJ2Mmaks 4GvmUD8hxxxPFR6ktuqfRV+FXqTfWwpgsEMxDObLIyjjQGiVH/FrlauO+mcXqB8z+VAi dQIubIbpv4bs76KMAeFFsZVzjtVDsw+e7q7yyzFe7wAF+ivhq+1dQjDD6/ZuQLMkkyBK rN/TOpEF+6fYL5THUGPS/jsIBGhC7mFvqrDYmaou5jDirLtk6LIHbNuxbzW4fSBZvMXv tm2ffMa+2eBq2mmTCO42a+tM+ULfZRMJK0lsuUjKtegzVZpkTOeS7jO8n1269k/yzNrp gQMg== X-Received: by 10.112.75.195 with SMTP id e3mr8811759lbw.54.1368247396654; Fri, 10 May 2013 21:43:16 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPSA id pm9sm1771469lbb.8.2013.05.10.21.43.15 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Fri, 10 May 2013 21:43:16 -0700 (PDT) Date: Sat, 11 May 2013 08:43:12 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] fix grub-install efibootmgr presence test with --removable Message-ID: <20130511084312.4bfc9ac6@opensuse.site> In-Reply-To: <518D0AE2.4010606@gmail.com> References: <20130509104434.GG28516@rocoto.smurfnet.nu> <518D0AE2.4010606@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/8JkoDf5q4ShqK6iyML8.IpR"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.182 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 May 2013 04:43:21 -0000 --Sig_/8JkoDf5q4ShqK6iyML8.IpR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Fri, 10 May 2013 16:57:38 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 09.05.2013 12:44, Leif Lindholm wrote: >=20 > > When executed for an EFI target, grub-install checks for the path of > > efibootmgr - however, this utility is not required (or used) when > > installing to a removable media (with --removable). > >=20 >=20 > This patch would simply ignore the problem. I comitted another fix which > is cleaner. >=20 Note that "which command" already prints error message when command was not found, so additional error output is strictly speaking redundant. --Sig_/8JkoDf5q4ShqK6iyML8.IpR Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlGNzGMACgkQR6LMutpd94xF9gCff9caRYEFu8QmkD8j/DW3qewU OXcAoMnqzRjUtRFOOhQteFrVT0VRZX5j =ohxj -----END PGP SIGNATURE----- --Sig_/8JkoDf5q4ShqK6iyML8.IpR--